Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apisix restart failed (#10495) #10696

Merged
merged 14 commits into from
Jan 3, 2024
Merged

fix: apisix restart failed (#10495) #10696

merged 14 commits into from
Jan 3, 2024

Conversation

hanqingwu
Copy link
Contributor

@hanqingwu hanqingwu commented Dec 22, 2023 •
edited
Loading

Description

when apisix is running and after kill, it return to exit and skip start new instance
Fixes # (issue)

fix: apisix restart failed (#10495)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

shreemaan-abhishek
shreemaan-abhishek requested changes Dec 22, 2023
View reviewed changes
apisix/cli/ops.lua Outdated Show resolved Hide resolved
@shreemaan-abhishek
Copy link
Contributor

please fix the CI

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Dec 25, 2023
@hanqingwu
Copy link
Contributor Author

@shreemaan-abhishek , can you review it .

@monkeyDluffy6017
Copy link
Contributor

please merge the master branch

@hanqingwu
Copy link
Contributor Author

@monkeyDluffy6017 , can you tell me what shoud i do ? 1 change requested by @shreemaan-abhishek ?

@hanqingwu
Copy link
Contributor Author

Hi @monkeyDluffy6017 , can you approve reviews ?

monkeyDluffy6017
monkeyDluffy6017 reviewed Jan 2, 2024
View reviewed changes
apisix/cli/ops.lua Outdated Show resolved Hide resolved
monkeyDluffy6017
monkeyDluffy6017 reviewed Jan 2, 2024
View reviewed changes
apisix/cli/ops.lua Outdated Show resolved Hide resolved
monkeyDluffy6017
monkeyDluffy6017 reviewed Jan 2, 2024
View reviewed changes
apisix/cli/ops.lua Outdated Show resolved Hide resolved
monkeyDluffy6017
monkeyDluffy6017 reviewed Jan 3, 2024
View reviewed changes
apisix/cli/ops.lua Outdated Show resolved Hide resolved
@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR labels Jan 3, 2024
@monkeyDluffy6017 monkeyDluffy6017 merged commit 88107db into apache:master Jan 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanqingwu @shreemaan-abhishek @monkeyDluffy6017