fix: don't require etcd under deployment #10528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navendu Pottekkat <[email protected]>
pottekkat
force-pushed
the
fix/schema/2
branch
from
54ccfc8 to
c2e8bdd
Compare
shreemaan-abhishek
approved these changes
Nov 22, 2023
Sn0rt
approved these changes
Nov 22, 2023
monkeyDluffy6017
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CLI tests seem to be failing repeatedly, although when the schema was updated in #10339 the tests were passing.
If the schema change is causing issues, we might need to revert that PR and find the underlying issue.
This PR tries to fix the possible issue with the schema that might be causing the tests to fail.
Checklist