feat: body-transformer plugin enhancement(#10472) #10496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you plan to support gzip as mentioned in the linked issue? |
The apisix gateway usually transmits data through the intranet and upstream. I think there are very few usage scenarios of gzip on the intranet, and gzip will greatly reduce the performance of apisix. What do you think? |
t/plugin/body-transformer.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 15: The template uses x-www-form-urlencoded format |
There was a problem hiding this comment.
Wrong title? test template_is_base64 here? what's the purpose of this test case?
monkeyDluffy6017
added
the
wait for update
|
The ci is unstable, i will approve this after fix the ci |
|
@yongxiaodong please merge the master to fix the ci |
|
CI still has errors |
|
done |
monkeyDluffy6017
approved these changes
Nov 27, 2023
monkeyDluffy6017
added
approved
and removed
wait for update
shreemaan-abhishek
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10472
Checklist