Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update realm attribute description in OIDC plugin #10492

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

kayx23
Copy link
Member

@kayx23 kayx23 commented Nov 15, 2023

Description

Update realm description in the OIDC plugin to explain how this attribute is actually used by APISIX after checking the code. The English doc didn't do enough explanation and the Chinese doc was explaining what realm was. It was unclear why one should configure this attribute, as realm is usually already part of the discovery endpoint.

References

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@moonming moonming merged commit 44b1a48 into apache:master Nov 15, 2023
7 checks passed
@kayx23 kayx23 deleted the oidc-realm branch November 15, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants