Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: passive health check seems never provide a healthy report #1640

Closed
spacewander opened this issue Jun 2, 2020 · 1 comment · Fixed by #1918
Closed

question: passive health check seems never provide a healthy report #1640

spacewander opened this issue Jun 2, 2020 · 1 comment · Fixed by #1918
Assignees
@membphis
Labels
bug Something isn't working

Comments

@spacewander
Copy link
Member

https://github.com/apache/incubator-apisix/blob/82f85e59465c80e27879d9985461d60fe4f77721/apisix/balancer.lua#L254-L269

Currently we only report the HTTP status in the test next stage. However, only unhealthy upstream will trigger a test next try. Does the passive health check make any report when an unhealthy upstream goes healthy? Does the healthy part of the passive health configuration work as expected?
https://github.com/apache/incubator-apisix/blob/82f85e59465c80e27879d9985461d60fe4f77721/apisix/schema_def.lua#L159
@membphis
Copy link
Member

I think we can fix it in the log phase.

@membphis membphis added the bug Something isn't working label Jun 21, 2020
@membphis membphis self-assigned this Jul 28, 2020
@membphis membphis mentioned this issue Jul 28, 2020
Merged
4 tasks
membphis added a commit that referenced this issue Jul 31, 2020
@membphis
bugfix: passive health check seems never provide a healthy report (#1918
2ba0231 
)

Fix #1640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@membphis membphis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: passive health check seems never provide a healthy report
2 participants
@spacewander @membphis