fix test case

apache · Feb 12, 2021 · c0f146e · c0f146e
1 parent 6bbe7ea
commit c0f146e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/apisix/plugins/response-rewrite.lua b/apisix/plugins/response-rewrite.lua
@@ -69,15 +69,15 @@ local _M = {
 
 local function vars_matched(conf, ctx)
     if not conf.vars then
-        return false
+        return true
     end
 
     if not conf.response_expr then
         local response_expr, _ = expr.new(conf.vars)
         conf.response_expr = response_expr
     end
 
-    local match_result = conf.response_expr:eval(ctx.vars)
+    local match_result = conf.response_expr:eval(ctx.var)
 
     return match_result
 end
@@ -128,7 +128,7 @@ do
 function _M.body_filter(conf, ctx)
 
     local ok =  vars_matched(conf, ctx)
-    if ok then
+    if not ok then
         return
     end
 
@@ -147,7 +147,7 @@ end
 function _M.header_filter(conf, ctx)
 
     local ok =  vars_matched(conf, ctx)
-    if ok then
+    if not ok then
         return
     end
 

diff --git a/t/APISIX.pm b/t/APISIX.pm
@@ -93,6 +93,10 @@ apisix:
     tcp:
       - 9100
   admin_key: null
+etcd:
+  host:
+    - "http://172.19.4.10:2479" 
+  prefix: "/apisix"
 _EOC_
 
 my $etcd_enable_auth = $ENV{"ETCD_ENABLE_AUTH"} || "false";

diff --git a/t/plugin/response-rewrite.t b/t/plugin/response-rewrite.t
@@ -126,7 +126,7 @@ property "body" validation failed: wrong type: expected string, got number
                             "headers" : {
                                 "X-Server-id": 3,
                                 "X-Server-status": "on",
-                                "Content-Type": "22"
+                                "Content-Type": ""
                             },
                             "body": "new body\n"
                         }
@@ -561,8 +561,8 @@ GET /server_error
 new body3
 --- error_code eval
 403
---- no_error_log
-[error]
+--- error_log
+500 Internal Server Error