Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation path naming for apisix-java-plugin-runner #385

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

iamayushdas
Copy link
Contributor

@iamayushdas iamayushdas commented Jun 24, 2021

Fixes: #[Add issue number here]

Changes:

fixed the navigation path name for apisix-java-plugin-runner

Screenshot 2021-06-24 at 8 14 12 PM

@netlify
Copy link

netlify bot commented Jun 24, 2021

✔️ Deploy Preview for apisix ready!

🔨 Explore the source changes: f32b61a

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix/deploys/60d93fd20331c80007687fbe

😎 Browse the preview: https://deploy-preview-385--apisix.netlify.app

@iamayushdas
Copy link
Contributor Author

cc @juzhiyuan @Yiyiyimu
till then that uniform id proposal did not pass this will work

@juzhiyuan juzhiyuan requested a review from Yiyiyimu June 27, 2021 04:03
@juzhiyuan
Copy link
Member

LGTM, thanks!

@Yiyiyimu
Copy link
Member

It seems I can not see apisix-java-runner in navbar, is that expected?
image

@iamayushdas
Copy link
Contributor Author

iamayushdas commented Jun 28, 2021

It seems I can not see apisix-java-runner in navbar, is that expected?
image

No, there should be apisix-java-runner, I think you have unmerged changes @Yiyiyimu

@Yiyiyimu
Copy link
Member

@iamayushdas you can check the preview page

@iamayushdas
Copy link
Contributor Author

@iamayushdas you can check the preview page

oops, we got a problem here

@iamayushdas iamayushdas marked this pull request as draft June 28, 2021 02:49
@iamayushdas iamayushdas marked this pull request as ready for review June 28, 2021 04:08
@iamayushdas
Copy link
Contributor Author

@Yiyiyimu have a look again please

@Yiyiyimu Yiyiyimu merged commit 38ef79e into apache:master Jun 28, 2021
1502shivam-singh pushed a commit to 1502shivam-singh/apisix-website that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants