chore: add alpha channel to showcase image for dark mode #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yiyiyimu <[email protected]>
|
Deploy preview for apisix ready! Built with commit e9c85cc |
|
Since the images coming from CDN, so the preview sites could not show updated images. It seems the only thing I could do is to add some screenshots of opening them locally in photoshop 🤦 Before: After: |
Signed-off-by: yiyiyimu <[email protected]>
Merged
|
Wow, I see so many images got updated, but some images seem broken or too dark? |
@juzhiyuan On my side, no images got updated 🤣 The reason is all images coming from CDN, and it would not got updated when only in PR. That's the same reason those two images got broken. I changed them from svg to png, so we could not use the original source from CDN anymore. |
juzhiyuan
approved these changes
Apr 14, 2021
membphis
approved these changes
Apr 16, 2021
1502shivam-singh
added a commit
to 1502shivam-singh/apisix-website
that referenced
this pull request
May 20, 2021
docs: added dashboard (apache#221) fix: pull request in place of apache#214 (apache#222) fix: changes to title style on landing page and doc addition Co-authored-by: Amit Wani <[email protected]> docs: added dashboard (apache#225) docs: added blog `Get Front-End Test Coverage with Cypress` (apache#227) fix: Wrong doc url (apache#231) fix: some url path can't replace by absolute url path (apache#237) Co-authored-by: coolsoul <[email protected]> Co-authored-by: 琚致远 <[email protected]> feat: support edit this page & update styles (apache#235) chore: fix release guide since doc layout changed (apache#238) docs: added Integrate with Projects documentations (apache#234) Co-authored-by: 琚致远 <[email protected]> added latest styles feat: algolia docSearch apache#226 (apache#241) docs: use getting-started for ingress-controller (apache#242) feat: upgrade APISIX version (apache#244) fix: add <!--truncate--> to the blog markdown files apache#240 (apache#247) fix: rectify the index doc page for apisix ingress controller (apache#249) fix: fix the version number in mobile size overflow (apache#245) fix: apache#220 (apache#239) docs: added event about releasing APISIX 2.4 (apache#248) docs: fixed broken powered-by.md link (apache#251) docs: update navbar for apisix (apache#252) fix: improved the description for users to join slack (apache#253) chore: Add new committer jinchen in committer list (apache#254) docs: add docs for ingress 0.4.0 (apache#258) * docs: add docs for ingress 0.4.0 * docs: modify ingress downloads * fix: lint fix: update sync-docs.js (apache#257) feat: improve documents synchronize (apache#262) feat: sync user wall data (apache#260) feat: support toggle sidebar (apache#269) chore: move Chao Zhang from Committers to PMCs (apache#267) feat: apache#216 add helm-chart project (apache#273) fix: add a bundle of good first issues links to homepage (apache#274) feat: support apisix-docker (apache#275) feat: broken link checker script (apache#263) Co-authored-by: 琚致远 <[email protected]> feat: apache#266 speed up static file (apache#270) feat: upgrade APISIX Dashboard version (apache#276) feat: support to load other projects (apache#277) chore(deps): bump peaceiris/actions-gh-pages from v3 to v3.8.0 (apache#271) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore: upgrade APISIX 2.5 (apache#279) chore: remove downloads for docker & helm chart (apache#284) feat: APISIX 2.5 event (apache#283) docs: added a new blog "Traffic Split in Apache APISIX Ingress Controller" (apache#286) chore: support dark mode and switch (apache#289) chore: support hide navbar on scroll down (apache#290) fix: page not found for apisix docker and apisix helm chart (apache#282) Co-authored-by: Ayush das <[email protected]> fix: add truncate and source to newly added blog (apache#296) * update traffic-split-in-ingress-controller.md * Update website/blog/2021-03-27-traffic-split-in-apache-apisix-ingress-controller.md Co-authored-by: John Bampton <[email protected]> Co-authored-by: John Bampton <[email protected]> fix: disable version switch button in sidebar, as website doesn't support it (apache#299) fix: padding to arrow inside collapse sidebar button, and fit button to sidebar width (apache#300) fix: darkMode enhanced (apache#297) chore: release ingress controller 0.5.0 (apache#305) * chore: release ingress controller 0.5.0 * feat: add event fix: broken link in release guide (apache#306) docs: update the architecture diagram (apache#309) chore: add alpha channel to showcase image for dark mode (apache#303) Signed-off-by: yiyiyimu <[email protected]> chore: Fix GitHub-icon sizes in team page (apache#313) docs: update logo wall (apache#315) chore: upgrade APISIX Dashboard version to 2.6 (apache#317) docs: update logo wall (apache#316) docs: update download link (apache#320) docs: update integration page (apache#327) chore: Test Docusaurus webpack 5 support (apache#318) feat: added last updated time (apache#331) docs: fix broken links in Run Ingress on Amazon EKS blog (apache#333) update docusaurus.config.json (apache#334) feat: darkmode added to download-dropdown (apache#336) Co-authored-by: 琚致远 <[email protected]> chore(deps): bump actions/setup-python from 2 to 2.2.2 (apache#339) Signed-off-by: dependabot[bot] <[email protected]> chore(deps): bump actions/checkout from 2 to 2.3.4 (apache#337) Signed-off-by: dependabot[bot] <[email protected]> chore(deps): bump actions/setup-node from 2 to 2.1.5 (apache#338) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> release ingress 0.6.0 (apache#343) docs: include Helm charts and Docker to documents page (apache#342) feat: added meta image (apache#345) squashing: merge history commits on docs and landing page
1502shivam-singh
added a commit
to 1502shivam-singh/apisix-website
that referenced
this pull request
May 20, 2021
docs: added dashboard (apache#221) fix: pull request in place of apache#214 (apache#222) fix: changes to title style on landing page and doc addition Co-authored-by: Amit Wani <[email protected]> docs: added dashboard (apache#225) docs: added blog `Get Front-End Test Coverage with Cypress` (apache#227) fix: Wrong doc url (apache#231) fix: some url path can't replace by absolute url path (apache#237) Co-authored-by: coolsoul <[email protected]> Co-authored-by: 琚致远 <[email protected]> feat: support edit this page & update styles (apache#235) chore: fix release guide since doc layout changed (apache#238) docs: added Integrate with Projects documentations (apache#234) Co-authored-by: 琚致远 <[email protected]> added latest styles feat: algolia docSearch apache#226 (apache#241) docs: use getting-started for ingress-controller (apache#242) feat: upgrade APISIX version (apache#244) fix: add <!--truncate--> to the blog markdown files apache#240 (apache#247) fix: rectify the index doc page for apisix ingress controller (apache#249) fix: fix the version number in mobile size overflow (apache#245) fix: apache#220 (apache#239) docs: added event about releasing APISIX 2.4 (apache#248) docs: fixed broken powered-by.md link (apache#251) docs: update navbar for apisix (apache#252) fix: improved the description for users to join slack (apache#253) chore: Add new committer jinchen in committer list (apache#254) docs: add docs for ingress 0.4.0 (apache#258) * docs: add docs for ingress 0.4.0 * docs: modify ingress downloads * fix: lint fix: update sync-docs.js (apache#257) feat: improve documents synchronize (apache#262) feat: sync user wall data (apache#260) feat: support toggle sidebar (apache#269) chore: move Chao Zhang from Committers to PMCs (apache#267) feat: apache#216 add helm-chart project (apache#273) fix: add a bundle of good first issues links to homepage (apache#274) feat: support apisix-docker (apache#275) feat: broken link checker script (apache#263) Co-authored-by: 琚致远 <[email protected]> feat: apache#266 speed up static file (apache#270) feat: upgrade APISIX Dashboard version (apache#276) feat: support to load other projects (apache#277) chore(deps): bump peaceiris/actions-gh-pages from v3 to v3.8.0 (apache#271) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore: upgrade APISIX 2.5 (apache#279) chore: remove downloads for docker & helm chart (apache#284) feat: APISIX 2.5 event (apache#283) docs: added a new blog "Traffic Split in Apache APISIX Ingress Controller" (apache#286) chore: support dark mode and switch (apache#289) chore: support hide navbar on scroll down (apache#290) fix: page not found for apisix docker and apisix helm chart (apache#282) Co-authored-by: Ayush das <[email protected]> fix: add truncate and source to newly added blog (apache#296) * update traffic-split-in-ingress-controller.md * Update website/blog/2021-03-27-traffic-split-in-apache-apisix-ingress-controller.md Co-authored-by: John Bampton <[email protected]> Co-authored-by: John Bampton <[email protected]> fix: disable version switch button in sidebar, as website doesn't support it (apache#299) fix: padding to arrow inside collapse sidebar button, and fit button to sidebar width (apache#300) fix: darkMode enhanced (apache#297) chore: release ingress controller 0.5.0 (apache#305) * chore: release ingress controller 0.5.0 * feat: add event fix: broken link in release guide (apache#306) docs: update the architecture diagram (apache#309) chore: add alpha channel to showcase image for dark mode (apache#303) Signed-off-by: yiyiyimu <[email protected]> chore: Fix GitHub-icon sizes in team page (apache#313) docs: update logo wall (apache#315) chore: upgrade APISIX Dashboard version to 2.6 (apache#317) docs: update logo wall (apache#316) docs: update download link (apache#320) docs: update integration page (apache#327) chore: Test Docusaurus webpack 5 support (apache#318) feat: added last updated time (apache#331) docs: fix broken links in Run Ingress on Amazon EKS blog (apache#333) update docusaurus.config.json (apache#334) feat: darkmode added to download-dropdown (apache#336) Co-authored-by: 琚致远 <[email protected]> chore(deps): bump actions/setup-python from 2 to 2.2.2 (apache#339) Signed-off-by: dependabot[bot] <[email protected]> chore(deps): bump actions/checkout from 2 to 2.3.4 (apache#337) Signed-off-by: dependabot[bot] <[email protected]> chore(deps): bump actions/setup-node from 2 to 2.1.5 (apache#338) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> release ingress 0.6.0 (apache#343) docs: include Helm charts and Docker to documents page (apache#342) feat: added meta image (apache#345) squashing: merge history commits on docs and landing page set max-width attribute to docMainContainer class set max-width attribute to docMainContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yiyiyimu [email protected]
related to #297
Scripts thanks to https://stackoverflow.com/questions/35859140/remove-transparency-alpha-from-any-image-using-pil