Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP #1118] fix: add 400 second tag search debounce #1132

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

prithvidasgupta
Copy link
Contributor

Fix for #1118

Fixed:

  • Stop hammering the backend with every tag search key stroke ( 400 ms debounce)

Fixing:

  • Use old state till the debounce results come back.

@shuashuai shuashuai changed the base branch from main to dev October 17, 2024 02:05
@shuashuai
Copy link
Member

@prithvidasgupta

The PR you submitted is shown in Draft status. If you are sure you need to contribute to the PR, please set the PR status to normal first, and then we will review the feature.

@prithvidasgupta
Copy link
Contributor Author

@shuashuai I need to make a few more changes on this (I will do it during the weekend) but I guess I can open it for review.

@prithvidasgupta prithvidasgupta marked this pull request as ready for review October 17, 2024 10:25
Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@shuashuai
Copy link
Member

@shuashuai I need to make a few more changes on this (I will do it during the weekend) but I guess I can open it for review.

It doesn’t matter, you can continue to open a new PR to contribute

@shuashuai shuashuai merged commit 895c1c4 into apache:dev Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants