fix: branding favicon might be empty

apache · Aug 7, 2024 · 264f927 · 264f927
1 parent f0b5859
commit 264f927
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/controller/template_render/question.go b/internal/controller/template_render/question.go
@@ -96,9 +96,9 @@ func (t *TemplateRenderController) OpenSearch(ctx *gin.Context) {
 		return
 	}
 
-	favicon := "favicon.ico"
+	favicon := general.SiteUrl + "/favicon.ico"
 	branding, err := t.siteInfoService.GetSiteBranding(ctx)
-	if err == nil {
+	if err == nil && len(branding.Favicon) > 0 {
 		favicon = branding.Favicon
 	}