Remove airflow.bin package #7808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:Scheduler
potiuk
reviewed
Mar 22, 2020
| @@ -654,7 +654,11 @@ def do_setup(pinned=False): | |||
| }, | |||
| include_package_data=True, | |||
| zip_safe=False, | |||
| scripts=['airflow/bin/airflow'], | |||
| entry_points={ | |||
| "console_scripts": [ | |||
potiuk
approved these changes
Mar 22, 2020
|
Docker is sad. I'm working on a fix. |
turbaszek
approved these changes
Mar 22, 2020
| from airflow.configuration import conf | ||
| from airflow.exceptions import AirflowException | ||
| from airflow.executors.executor_loader import ExecutorLoader | ||
| from airflow.utils.helpers import partition | ||
| from airflow.utils.module_loading import import_string | ||
| from airflow.utils.timezone import parse as parsedate | ||
|
|
||
| api.load_auth() |
Codecov Report
@@ Coverage Diff @@
## master #7808 +/- ##
==========================================
- Coverage 86.85% 86.60% -0.25%
==========================================
Files 925 925
Lines 44862 44873 +11
==========================================
- Hits 38964 38862 -102
- Misses 5898 6011 +113
Continue to review full report at Codecov.
|
This was referenced Dec 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the following changes:
We can now run airflow with the
python -m airflowcommand. This may be helpful in some environments, e.g. Windows. Using entry_points can also improve Windos compatibility - https://setuptools.readthedocs.io/en/latest/setuptools.html#automatic-script-creationIssue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.