Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4062] Improve docs on install extra package commands #4966

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

zhongjiajie
Copy link
Member

Some command for installing extra packages like
pip install apache-airflow[devel] cause error
in special situation/shell, We should clear them
by add quotation like
pip install 'apache-airflow[devel]'

Make sure you have checked all steps below.

Code Quality

  • Passes flake8

@zhongjiajie
Copy link
Member Author

zhongjiajie commented Mar 24, 2019

From #4897, sorry for break our CI test in #4897

@zhongjiajie
Copy link
Member Author

CI doc check pass, but failed in main test. https://travis-ci.org/apache/airflow/builds/510600306?utm_source=github_status&utm_medium=notification
Maybe I should force push to restart CI?

@zhongjiajie zhongjiajie force-pushed the docs_clear_install_package_command branch 2 times, most recently from 6721305 to aa3ad79 Compare March 25, 2019 09:49
Some command for installing extra packages like
`pip install apache-airflow[devel]` cause error
in special situation/shell, We should clear them
by add quotation like
`pip install 'apache-airflow[devel]'`
@zhongjiajie zhongjiajie force-pushed the docs_clear_install_package_command branch from aa3ad79 to 422f54f Compare March 25, 2019 10:51
@zhongjiajie
Copy link
Member Author

@ashb CI failed several times, and it's unrelated. This PR just change docs and log so I think it could be merge.

@ashb ashb merged commit ffe1412 into apache:master Mar 25, 2019
@zhongjiajie
Copy link
Member Author

@ashb Thanks.

@zhongjiajie zhongjiajie deleted the docs_clear_install_package_command branch March 25, 2019 12:22
ashb pushed a commit that referenced this pull request Mar 25, 2019
Some command for installing extra packages like
`pip install apache-airflow[devel]` cause error
in special situation/shell, We should clear them
by add quotation like
`pip install 'apache-airflow[devel]'`
@zhongjiajie
Copy link
Member Author

@ashb I found out you make jira ticket status "RESOLVED", It nessary for me to change jira ticket when PR was merge? Ask that because I found out them will change status auto when related PR be merge.

@ashb
Copy link
Member

ashb commented Mar 25, 2019

The commiter usually marks the Jira ticket as resolved, but we forget sometimes. If we don't, yes you can mark your own Jira tickets as resolved. If you do please also set the Fix Version field - to 2.0.0 or 1.10.3 depending on if it's a large/backwards-incompatible change or not.

@zhongjiajie
Copy link
Member Author

I got it, thanks @ashb

gseva added a commit to gseva/incubator-airflow that referenced this pull request Apr 4, 2019
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
…#4966)

Some command for installing extra packages like
`pip install apache-airflow[devel]` cause error
in special situation/shell, We should clear them
by add quotation like
`pip install 'apache-airflow[devel]'`
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
…#4966)

Some command for installing extra packages like
`pip install apache-airflow[devel]` cause error
in special situation/shell, We should clear them
by add quotation like
`pip install 'apache-airflow[devel]'`
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
…#4966)

Some command for installing extra packages like
`pip install apache-airflow[devel]` cause error
in special situation/shell, We should clear them
by add quotation like
`pip install 'apache-airflow[devel]'`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants