[AIRFLOW-3933] Fix various typos #4747

ryanyuan · 2019-02-21T06:23:10Z

Fix typos

Make sure you have checked all steps below.

Jira

My PR addresses the following Airflow-3933 issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

Here are some details about my PR, including screenshots of any UI changes:

Commits

My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters (not including Jira issue reference)
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Code Quality

Passes flake8

Fix typos

zhongjiajie · 2019-02-21T06:40:48Z

@ryanyuan Awesome!

drewsonne · 2019-02-21T06:57:11Z

airflow/contrib/operators/dataproc_operator.py

@@ -1376,7 +1376,7 @@ def execute(self, context):
        self.hook.wait(self.start())

    def start(self, context):
-        raise AirflowException('plese start a workflow operation')
+        raise AirflowException('please start a workflow operation')


Not sure what the convention is, but maybe should be capitalised?

drewsonne · 2019-02-21T06:57:51Z

dev/airflow-pr

@@ -63,7 +63,7 @@ AIRFLOW_GIT_LOCATION = os.environ.get(
    "AIRFLOW_GIT",
    os.path.dirname(os.path.dirname(os.path.realpath(__file__))))

-# Remote name which points to the Gihub site
+# Remote name which points to the Github site


I think it should be GitHub

codecov-io · 2019-02-21T07:11:33Z

Codecov Report

Merging #4747 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4747   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files         430      430           
  Lines       28009    28009           
=======================================
  Hits        20900    20900           
  Misses       7109     7109

Impacted Files	Coverage Δ
...ow/contrib/example_dags/example_qubole_operator.py	`0% <ø> (ø)`	⬆️
airflow/operators/presto_check_operator.py	`0% <ø> (ø)`	⬆️
airflow/contrib/hooks/salesforce_hook.py	`0% <ø> (ø)`	⬆️
airflow/contrib/hooks/azure_data_lake_hook.py	`92.85% <ø> (ø)`	⬆️
airflow/contrib/operators/cassandra_to_gcs.py	`63.31% <ø> (ø)`	⬆️
airflow/contrib/operators/dataflow_operator.py	`100% <ø> (ø)`	⬆️
airflow/contrib/hooks/qubole_hook.py	`53.65% <ø> (ø)`	⬆️
airflow/contrib/hooks/fs_hook.py	`90% <ø> (ø)`	⬆️
airflow/contrib/operators/awsbatch_operator.py	`83.33% <ø> (ø)`	⬆️
...rflow/contrib/operators/bigquery_check_operator.py	`0% <ø> (ø)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d6c1a...520c038. Read the comment docs.

codecov-io · 2019-02-21T07:11:34Z

Codecov Report

Merging #4747 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #4747      +/-   ##
==========================================
- Coverage   74.61%   74.61%   -0.01%     
==========================================
  Files         430      430              
  Lines       28009    28009              
==========================================
- Hits        20900    20899       -1     
- Misses       7109     7110       +1

Impacted Files	Coverage Δ
...ow/contrib/example_dags/example_qubole_operator.py	`0% <ø> (ø)`	⬆️
airflow/operators/presto_check_operator.py	`0% <ø> (ø)`	⬆️
airflow/contrib/hooks/salesforce_hook.py	`0% <ø> (ø)`	⬆️
airflow/contrib/hooks/azure_data_lake_hook.py	`92.85% <ø> (ø)`	⬆️
airflow/contrib/operators/cassandra_to_gcs.py	`63.31% <ø> (ø)`	⬆️
airflow/contrib/operators/dataflow_operator.py	`100% <ø> (ø)`	⬆️
airflow/contrib/hooks/qubole_hook.py	`53.65% <ø> (ø)`	⬆️
airflow/contrib/hooks/fs_hook.py	`90% <ø> (ø)`	⬆️
airflow/contrib/operators/awsbatch_operator.py	`83.33% <ø> (ø)`	⬆️
...rflow/contrib/operators/bigquery_check_operator.py	`0% <ø> (ø)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d6c1a...bd44117. Read the comment docs.

Fix typos

XD-DENG · 2019-02-21T08:54:12Z

@ryanyuan awesome!

A minor minor suggestion: if all changes in your PR are purely doc change, you can add "[ci skip]" in your git commit message to skip the CI, so that it can save ASF a small amount of money.

zhongjiajie · 2019-02-21T09:08:00Z

@XD-DENG I donnot know CI test need money before. Isn't travis-ci free for open source project?

XD-DENG · 2019-02-21T09:11:21Z

Hi @zhongjiajie , Yes it is free for open source projects, but for relatively small size ones. If you integrate your Airflow fork with TravisCI, you will find that it's free but you can only run 5 tests concurrently.

ASF is using a subscribed service from Travis so Apache projects like Airflow's CI on Travis can run "unlimited" concurrent tests. It's not free in that case.

I got to know this from Ash earlier: #3967 (comment) (both "[ci skip]" and "[skip ci]" would work I remember)

ryanyuan · 2019-02-21T10:29:15Z

@XD-DENG Thanks for the tips!

zhongjiajie · 2019-02-21T10:46:56Z

@XD-DENG I get this, thanks.

Fokko · 2019-02-21T10:50:34Z

Thanks @ryanyuan

Fix typos

[AIRFLOW-3933] Fix various typos

520c038

Fix typos

drewsonne reviewed Feb 21, 2019

View reviewed changes

[AIRFLOW-3933] Fix various typos

bd44117

Fix typos

Fokko merged commit 5c170f0 into apache:master Feb 21, 2019

antonimaciej pushed a commit to PolideaInternal/airflow that referenced this pull request Feb 26, 2019

[AIRFLOW-3933] Fix various typos (apache#4747)

6136833

Fix typos

ashb pushed a commit that referenced this pull request Mar 7, 2019

[AIRFLOW-3933] Fix various typos (#4747)

8b33948

Fix typos

wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019

[AIRFLOW-3933] Fix various typos (apache#4747)

10e5e5e

Fix typos

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIRFLOW-3933] Fix various typos #4747

[AIRFLOW-3933] Fix various typos #4747

ryanyuan commented Feb 21, 2019 •

edited

Loading

zhongjiajie commented Feb 21, 2019

drewsonne Feb 21, 2019

drewsonne Feb 21, 2019

codecov-io commented Feb 21, 2019

codecov-io commented Feb 21, 2019 •

edited

Loading

XD-DENG commented Feb 21, 2019

zhongjiajie commented Feb 21, 2019

XD-DENG commented Feb 21, 2019 •

edited

Loading

ryanyuan commented Feb 21, 2019

zhongjiajie commented Feb 21, 2019

Fokko commented Feb 21, 2019

[AIRFLOW-3933] Fix various typos #4747

[AIRFLOW-3933] Fix various typos #4747

Conversation

ryanyuan commented Feb 21, 2019 • edited Loading

Jira

Description

Commits

Code Quality

zhongjiajie commented Feb 21, 2019

drewsonne Feb 21, 2019

Choose a reason for hiding this comment

drewsonne Feb 21, 2019

Choose a reason for hiding this comment

codecov-io commented Feb 21, 2019

Codecov Report

codecov-io commented Feb 21, 2019 • edited Loading

Codecov Report

XD-DENG commented Feb 21, 2019

zhongjiajie commented Feb 21, 2019

XD-DENG commented Feb 21, 2019 • edited Loading

ryanyuan commented Feb 21, 2019

zhongjiajie commented Feb 21, 2019

Fokko commented Feb 21, 2019

ryanyuan commented Feb 21, 2019 •

edited

Loading

codecov-io commented Feb 21, 2019 •

edited

Loading

XD-DENG commented Feb 21, 2019 •

edited

Loading