Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transient issue in main #45947

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

vincbeck
Copy link
Contributor

#45820 was created to disable one flaky test that causes some failures in the CI for times to times. Shamefully .... I added the @pytest.mark.skip( to the implementation and not the test ... 😭 . This PR actually skips the test.

Example of error: https://apache-airflow.slack.com/archives/C015SLQF059/p1737578261968529


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/skip_test_login_submit branch from fcff5f1 to 84748db Compare January 22, 2025 20:46
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@jedcunningham jedcunningham merged commit c092d44 into apache:main Jan 23, 2025
45 checks passed
@vincbeck vincbeck deleted the vincbeck/skip_test_login_submit branch January 23, 2025 15:17
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 27, 2025
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants