Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated code from hashicorp provider #44598

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Dec 3, 2024

related: #44559

Removed deprecated code from hashicorp provider


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:hashicorp Hashicorp provider related issues labels Dec 3, 2024
@Prab-27 Prab-27 force-pushed the depricate-changelog branch 3 times, most recently from ef5a41b to 7301029 Compare December 3, 2024 11:06
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I wonder why no unit test are failing - could you please check it out?

providers/src/airflow/providers/hashicorp/hooks/vault.py Outdated Show resolved Hide resolved
@Prab-27 Prab-27 force-pushed the depricate-changelog branch from 7301029 to e674c6a Compare December 4, 2024 13:18
@Prab-27
Copy link
Contributor Author

Prab-27 commented Dec 4, 2024

Done

@shahar1 shahar1 merged commit 696cb29 into apache:main Dec 6, 2024
65 checks passed
Copy link

boring-cyborg bot commented Dec 6, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Remove deprecated code from HashiCorp provider

* Remove additional deprecated code from hashicorp  provider

* remove test code for deprecated method

* fix if clause for approle authentication

* modified changelog

---------

Co-authored-by: pratiksha rajendrabhai badheka <pratiksha@DESKTOP-T5HUA05>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:hashicorp Hashicorp provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants