-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host_proxy_cmd parameter to SSHHook and SFTPHook #44565
Add host_proxy_cmd parameter to SSHHook and SFTPHook #44565
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
LGTM |
Tests need to be fixed @ajitg25 - apparently those tests depend on ncat being available in the environment, and we should not rely on it. |
…https://github.com/ajitg25/airflow into Add-host_proxy_cmd-parameter-to-SSHHook-and-SFTPHook
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Add host_proxy_cmd parameter to SSHHook and SFTPHook * Fix unit test case by mocking the paramiko.ProxyCommand * Fixed test cases by adding timeout=None
closes: #43636
Added the
host_proxy_cmd
parameter toSSHHook
andSFTPHook
.Added unit tests to validate the changes in
SSHHook
andSFTPHook
.