Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host_proxy_cmd parameter to SSHHook and SFTPHook #44565

Conversation

ajitg25
Copy link
Contributor

@ajitg25 ajitg25 commented Dec 2, 2024

closes: #43636

Added the host_proxy_cmd parameter to SSHHook and SFTPHook.
Added unit tests to validate the changes in SSHHook and SFTPHook.

Copy link

boring-cyborg bot commented Dec 2, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk marked this pull request as ready for review December 2, 2024 23:57
@potiuk
Copy link
Member

potiuk commented Dec 2, 2024

LGTM

@potiuk
Copy link
Member

potiuk commented Dec 3, 2024

Tests need to be fixed @ajitg25 - apparently those tests depend on ncat being available in the environment, and we should not rely on it.

@ajitg25
Copy link
Contributor Author

ajitg25 commented Dec 3, 2024

Tests need to be fixed @ajitg25 - apparently those tests depend on ncat being available in the environment, and we should not rely on it.

@potiuk Apologies, it was a miss from my side. Now, I have fixed the unit test cases in both files. PTAL!!

test_ssh
Screenshot 2024-12-03 at 8 31 33 AM

test_sftp
WhatsApp Image 2024-12-03 at 08 39 54

@potiuk potiuk merged commit a3a5969 into apache:main Dec 3, 2024
65 checks passed
Copy link

boring-cyborg bot commented Dec 3, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Add host_proxy_cmd parameter to SSHHook and SFTPHook

* Fix unit test case by mocking the paramiko.ProxyCommand

* Fixed test cases by adding timeout=None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH/SFTP over socks proxy - host_proxy_cmd as extra param
2 participants