Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider Deprecations in Standard #44541

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Dec 1, 2024

In Airflow 3 Dev Call we discussed and made a LAZY CONSENSUS to remove all deprecation's in providers prior 2.11 release in https://lists.apache.org/thread/lhy7zhz8yxo3jjpln0ds8ogszgb9b469.

This PR is the first for the provider Standard

As I fear a bit of side-effects, I force full tests.

@jscheffl jscheffl added full tests needed We need to run full set of tests for this PR to merge airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes provider:standard labels Dec 1, 2024
@jscheffl jscheffl requested a review from eladkal December 1, 2024 18:28
@jscheffl jscheffl removed the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Dec 1, 2024
@potiuk potiuk merged commit c44690c into apache:main Dec 1, 2024
97 checks passed
@potiuk
Copy link
Member

potiuk commented Dec 1, 2024

One thing more I realized - I think we need to add a CHANGELOG entry - that will eventually will land in a single "1.0" changelog for "standard" provider. Cc: @eladkal -> we need to find out a way to tell our users - surely, you can use the "standar" operators from here - but here is the list of things that changed in it since the "built-in" ones.

@jscheffl
Copy link
Contributor Author

jscheffl commented Dec 1, 2024

Yes, actually discussed the same with @eladkal in #44542 - just someone need to tell me "how to make it right"

@potiuk
Copy link
Member

potiuk commented Dec 1, 2024

Yes, actually discussed the same with @eladkal in #44542 - just someone need to tell me "how to make it right"

Just add messages to CHANGELOG.rst for the provider ? - we can then combine all the changelog entries for 0.* versions when we release 1.0. Does it sound good as "making things right" @eladkal @jscheffl :D ?

@eladkal
Copy link
Contributor

eladkal commented Dec 2, 2024

I don't think it's right to wait for 1.0
The 0.0.x provider still goes into constraints file. We need the change log to explain users how to migrate

@potiuk
Copy link
Member

potiuk commented Dec 2, 2024

I don't think it's right to wait for 1.0 The 0.0.x provider still goes into constraints file. We need the change log to explain users how to migrate

Correct. What I proposed, was to continue adding it (as usual) and release in 0.n - but then when we release 1.0 with the target of being ready for "prime time" we could consolidate it manually and make a single "what's changed vs. built-in operators" release notes (and remove all the 0.* ones from 1.0 changelog). That sounds like an easy way to communicate to users - who will be looking at the changelog while migrating to Airflow 3, putting it all in 1.0 changelog will just give them all information in one place.

@jscheffl
Copy link
Contributor Author

jscheffl commented Dec 2, 2024

relates to #44559

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Remove Provider Deprecations in Standard

* Remove Provider Deprecations in Standard, catch decorators as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge provider:standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants