AIP-81 Move CLI Commands to directories according to Hybrid, Local and Remote #44538
Conversation
bugraoz93
requested review from
potiuk,
ashb,
hussein-awala,
dstandish,
ryanahamilton,
bbovenzi,
pierrejeambrun,
jscheffl and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:CLI
area:dev-tools
provider:cncf-kubernetes
|
Good that you separate big re-factoring and shifting files. Let's see if CI turns green, then after short screening I have no issue for fast merge. |
Some turns out red :( I will check it out shortly |
|
I am surprised that my local pre-commit didn't catch this. They were there but weren't added to with git 😓 |
bugraoz93
force-pushed
the
feat/44204/split-cli-commands
branch
2 times, most recently
from
7473149 to
4f31c92
Compare
|
You need to rebase / solve conflicts now @bugraoz93 |
bugraoz93
force-pushed
the
feat/44204/split-cli-commands
branch
from
4f31c92 to
89be8ed
Compare
|
Rebased, thanks a lot for the reviews! ❤️ |
|
This broke airflow 2.10 + apache-airflow-providers-celery 3.9.0 ModuleNotFoundError: No module named 'airflow.cli.commands.local_commands' |
Thanks @millin for bringing this up! |
|
Thanks for the catch. When is this fix expected to be released? |
closes: #44204
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.