Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Get Mapped Task Instance Tries #44303

Merged

Conversation

kandharvishnu
Copy link
Contributor

related to: #42370


@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 23, 2024
@rawwar rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 23, 2024
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_tries branch from 1b5e318 to 3c81dd4 Compare November 23, 2024 13:10
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks :)

Should be good to merge once the base branch is updated and merged.

I'll do a final review then.

@pierrejeambrun
Copy link
Member

Need rebasing and conflict solving.

@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_tries branch from a22e190 to bb4d86b Compare November 26, 2024 13:23
@kandharvishnu kandharvishnu requested a review from a user November 26, 2024 13:23
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_tries branch from b1f680a to 6879cf6 Compare November 26, 2024 14:39
@pierrejeambrun pierrejeambrun merged commit a238d06 into apache:main Nov 26, 2024
62 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* adding get_task_instance_tries code

* rebase

* rebase

* adding get_mapped_task_instance_tries code

* adding mark_fastapi_migration_done

* rebasing test cases

* rebasing task_instances.py

* updating map_index default value

---------

Co-authored-by: kandharvishnuu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants