-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Independently update source code changes in DagCode #44189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:db-migrations
PRs with DB migration
kind:documentation
labels
Nov 19, 2024
ephraimbuddy
force-pushed
the
dagcode-changes-update
branch
2 times, most recently
from
November 19, 2024 18:49
6a78fb2
to
bef4852
Compare
ephraimbuddy
force-pushed
the
dagcode-changes-update
branch
from
November 20, 2024 11:54
bef4852
to
dbbdad5
Compare
jedcunningham
approved these changes
Nov 25, 2024
When the source code changes but not structural changes that would trigger a new version, we should update the DagCode's source code. To do that, I removed the fileloc_hash, which is no longer necessary as we read the code from the DB. I also added the source_code_hash column, which is used to detect code changes and update the source code.
ephraimbuddy
force-pushed
the
dagcode-changes-update
branch
from
November 25, 2024 17:44
d8c421c
to
d1d503c
Compare
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Independently update source code changes in DagCode When the source code changes but not structural changes that would trigger a new version, we should update the DagCode's source code. To do that, I removed the fileloc_hash, which is no longer necessary as we read the code from the DB. I also added the source_code_hash column, which is used to detect code changes and update the source code. * fixup! Independently update source code changes in DagCode * fixup! fixup! Independently update source code changes in DagCode * fixup! fixup! fixup! Independently update source code changes in DagCode * fixup! fixup! fixup! fixup! Independently update source code changes in DagCode
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Independently update source code changes in DagCode When the source code changes but not structural changes that would trigger a new version, we should update the DagCode's source code. To do that, I removed the fileloc_hash, which is no longer necessary as we read the code from the DB. I also added the source_code_hash column, which is used to detect code changes and update the source code. * fixup! Independently update source code changes in DagCode * fixup! fixup! Independently update source code changes in DagCode * fixup! fixup! fixup! Independently update source code changes in DagCode * fixup! fixup! fixup! fixup! Independently update source code changes in DagCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source code changes but not structural changes that would trigger a new version, we should update the DagCode's source code.
To do that, I removed the fileloc_hash, which is no longer necessary as we read the code from the DB. I also added the source_code_hash column, which is used to detect code changes and update the source code.