Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independently update source code changes in DagCode #44189

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

ephraimbuddy
Copy link
Contributor

When the source code changes but not structural changes that would trigger a new version, we should update the DagCode's source code.

To do that, I removed the fileloc_hash, which is no longer necessary as we read the code from the DB. I also added the source_code_hash column, which is used to detect code changes and update the source code.

@ephraimbuddy ephraimbuddy force-pushed the dagcode-changes-update branch 2 times, most recently from 6a78fb2 to bef4852 Compare November 19, 2024 18:49
airflow/models/dagcode.py Show resolved Hide resolved
airflow/models/dagcode.py Show resolved Hide resolved
When the source code changes but not structural changes that would
trigger a new version, we should update the DagCode's source code.

To do that, I removed the fileloc_hash, which is no longer necessary
as we read the code from the DB. I also added the source_code_hash
column, which is used to detect code changes and update the source code.
@ephraimbuddy ephraimbuddy force-pushed the dagcode-changes-update branch from d8c421c to d1d503c Compare November 25, 2024 17:44
@ephraimbuddy ephraimbuddy merged commit 2d9e7a5 into apache:main Nov 25, 2024
45 checks passed
@ephraimbuddy ephraimbuddy deleted the dagcode-changes-update branch November 25, 2024 18:12
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Independently update source code changes in DagCode

When the source code changes but not structural changes that would
trigger a new version, we should update the DagCode's source code.

To do that, I removed the fileloc_hash, which is no longer necessary
as we read the code from the DB. I also added the source_code_hash
column, which is used to detect code changes and update the source code.

* fixup! Independently update source code changes in DagCode

* fixup! fixup! Independently update source code changes in DagCode

* fixup! fixup! fixup! Independently update source code changes in DagCode

* fixup! fixup! fixup! fixup! Independently update source code changes in DagCode
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Independently update source code changes in DagCode

When the source code changes but not structural changes that would
trigger a new version, we should update the DagCode's source code.

To do that, I removed the fileloc_hash, which is no longer necessary
as we read the code from the DB. I also added the source_code_hash
column, which is used to detect code changes and update the source code.

* fixup! Independently update source code changes in DagCode

* fixup! fixup! Independently update source code changes in DagCode

* fixup! fixup! fixup! Independently update source code changes in DagCode

* fixup! fixup! fixup! fixup! Independently update source code changes in DagCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants