Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use S3CopyObjectOperator in example_comprehend_document_classifier #44160

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

vincbeck
Copy link
Contributor

Today, the system test example_comprehend_document_classifier downloads 10 times the same file from Github and save it in s3. As a consequence, Github might block you access and return a 403. Let's be nice with Github and download it once and then copy it from s3 to s3


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Nov 18, 2024
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking thought, otherwise I think it makes sense.

providers/src/airflow/providers/amazon/aws/hooks/s3.py Outdated Show resolved Hide resolved
@vincbeck vincbeck force-pushed the vincbeck/comprehend branch from 83d97b6 to c6b5eb6 Compare November 18, 2024 21:34
@eladkal eladkal merged commit a60d105 into apache:main Nov 19, 2024
45 checks passed
@vincbeck vincbeck deleted the vincbeck/comprehend branch November 19, 2024 19:18
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants