Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: telegram send file Operator and Hook #44040

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

HaKkaz
Copy link
Contributor

@HaKkaz HaKkaz commented Nov 14, 2024

I found that the Slack provider has a send_file hook and related operator, so I want to implement a similar one for the Telegram provider!

If this is a good idea, I will add unit tests and any other necessary components later!

My first PR, which was related to unit tests, was submitted last month, so I am still a newcomer. Any suggestions or feedback on this work would be greatly appreciated!


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

- correct the key name in the kwargs to match the argument name of send_file
- replace send_message with send_file
@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

sure. Go ahead.

@HaKkaz HaKkaz force-pushed the feat/telegram-send-file branch from 1d60536 to 6b50e03 Compare November 16, 2024 16:35
@potiuk potiuk requested a review from Copilot November 16, 2024 21:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 suggestion.

providers/src/airflow/providers/telegram/hooks/telegram.py Outdated Show resolved Hide resolved
@potiuk potiuk merged commit 7c11944 into apache:main Nov 18, 2024
62 checks passed
kandharvishnu pushed a commit to kandharvishnu/airflow that referenced this pull request Nov 19, 2024

---------

Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Copilot <[email protected]>
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025

---------

Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants