Limit temporarily aiohttp to < 3.11.0
#43983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
approved these changes
Nov 13, 2024
potiuk
approved these changes
Nov 13, 2024
|
This PR (when you open failing output you can see it) revealed limitation on parsing development dependencies that should be installed for compatiblity testing. The fix is here: #43995 - but I think this limit should not be placed in devel-deps. I will take a look in a moment. |
|
This is a better fix #43998 - aiohttp is already a dependency of |
potiuk
requested changes
Nov 14, 2024
|
Even better fix #44006 |
|
Closing -> the fix from #44006 is much more "appropriate". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be reverted when pnuckowski/aioresponses#262 is merged and released
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.