-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Migrate test a connection to FastAPI API #43766
AIP-84 Migrate test a connection to FastAPI API #43766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
One small change before we merge but looking good overall, thanks.
297740a
to
0d4abee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change
0d4abee
to
5391f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge, need rebasing to solve conflicts.
5391f70
to
04dbfbf
Compare
04dbfbf
to
f275fd7
Compare
Rebased and solved the conflicts. |
* Migrate test a connection to fastapi * Remove NotFound error from docs * Remove Validation error which is handled by fastapi * Remove async for complying convention for methods * Fix pre-commit ruff
* Migrate test a connection to fastapi * Remove NotFound error from docs * Remove Validation error which is handled by fastapi * Remove async for complying convention for methods * Fix pre-commit ruff
closes: #42594
It includes unifying parameter naming conventions for
test_connections.py
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.