Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Migrate test a connection to FastAPI API #43766

Merged

Conversation

bugraoz93
Copy link
Collaborator

@bugraoz93 bugraoz93 commented Nov 6, 2024

closes: #42594
It includes unifying parameter naming conventions for test_connections.py


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 6, 2024
@bugraoz93 bugraoz93 added the legacy api Whether legacy API changes should be allowed in PR label Nov 6, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

One small change before we merge but looking good overall, thanks.

airflow/api_fastapi/core_api/routes/public/connections.py Outdated Show resolved Hide resolved
@bugraoz93 bugraoz93 force-pushed the feat/42594/test-connection-to-fastapi branch from 297740a to 0d4abee Compare November 7, 2024 22:33
pierrejeambrun
pierrejeambrun previously approved these changes Nov 8, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

airflow/api_fastapi/core_api/routes/public/connections.py Outdated Show resolved Hide resolved
@pierrejeambrun pierrejeambrun dismissed their stale review November 8, 2024 14:24

Need final change

@bugraoz93 bugraoz93 force-pushed the feat/42594/test-connection-to-fastapi branch from 0d4abee to 5391f70 Compare November 8, 2024 18:43
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, need rebasing to solve conflicts.

@bugraoz93 bugraoz93 force-pushed the feat/42594/test-connection-to-fastapi branch from 5391f70 to 04dbfbf Compare November 12, 2024 16:04
@bugraoz93 bugraoz93 force-pushed the feat/42594/test-connection-to-fastapi branch from 04dbfbf to f275fd7 Compare November 12, 2024 16:06
@bugraoz93
Copy link
Collaborator Author

Rebased and solved the conflicts.

@pierrejeambrun pierrejeambrun merged commit f924ecb into apache:main Nov 12, 2024
56 checks passed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Migrate test a connection to fastapi

* Remove NotFound error from docs

* Remove Validation error which is handled by fastapi

* Remove async for complying convention for methods

* Fix pre-commit ruff
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Migrate test a connection to fastapi

* Remove NotFound error from docs

* Remove Validation error which is handled by fastapi

* Remove async for complying convention for methods

* Fix pre-commit ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Test Connection to FastAPI
3 participants