Log message source details are grouped #43681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
type:bug-fix
jscheffl
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks for the fix, looks good for me - also valid to back-port to 2.10 line in my view.
@bbovenzi would it be okay to back-port also for you?
We had a couple of complaints from users who had (1) error markers in logs in UI even marked in red just because the celery worker was not delivering the logs internally - but logs were loaded from file successfully and (2) if logs were archived on blob storage the internal blob storage URL was posted which actually is not accessible for users.
So the first lines posted in the logs mainly confused and were not helpful... Donat came to the proposal to hide/log group them per default.
|
Moved back to draft until pytests are fixed |
|
Makes sense to me! |
jscheffl
reviewed
Nov 13, 2024
jscheffl
reviewed
Nov 13, 2024
jscheffl
reviewed
Nov 14, 2024
added 2 commits
November 15, 2024 09:46
jscheffl
pushed a commit
to jscheffl/airflow
that referenced
this pull request
Nov 15, 2024
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]>
jscheffl
pushed a commit
to jscheffl/airflow
that referenced
this pull request
Nov 16, 2024
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]> (cherry picked from commit 9d18772)
jscheffl
added a commit
that referenced
this pull request
Nov 17, 2024
* Log message source details are grouped (#43681) * Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]> (cherry picked from commit 9d18772) * Fix pytest --------- Co-authored-by: majorosdonat <[email protected]>
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
* Log message source details are grouped (#43681) * Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]> (cherry picked from commit 9d18772) * Fix pytest --------- Co-authored-by: majorosdonat <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Log message source details are grouped (#43681) * Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]> (cherry picked from commit 9d18772) * Fix pytest --------- Co-authored-by: majorosdonat <[email protected]>
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log message source details are grouped: they are not relevant for most users and can distract them from finding the root cause of their errors.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.