Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GlueJobTrigger serialization bug causing verbose to always be True #43622

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

jimwbaldwin
Copy link
Contributor

@jimwbaldwin jimwbaldwin commented Nov 4, 2024

related: #43620


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Nov 4, 2024
Copy link

boring-cyborg bot commented Nov 4, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@jimwbaldwin
Copy link
Contributor Author

It doesn't test the functionality of what I wanted to test as it does not defer and thats where the bug is. Trying to figure out how to test something that has been deferred and then resumed.

@eladkal eladkal requested review from ferruzzi and vincbeck November 4, 2024 14:03
@vincbeck
Copy link
Contributor

vincbeck commented Nov 4, 2024

Some static check failures, please fix them

@jimwbaldwin
Copy link
Contributor Author

Okay, I figured out how to find the bug we suspected and confirm it with a test. Please see the new test_serialization test in this PR.

Some static check failures, please fix them

I'll take a look at these soon.

@jimwbaldwin jimwbaldwin changed the title Add test for glue execute without verbose logging Add tests for glue execute without verbose logging and glue serialize Nov 4, 2024
serializing to a string makes True and False both true as any string is
true
@jimwbaldwin jimwbaldwin changed the title Add tests for glue execute without verbose logging and glue serialize Resolve GlueJobTrigger serialization bug causing verbose to always be True Nov 5, 2024
@jimwbaldwin
Copy link
Contributor Author

The GlueJobTrigger serialization test before I fixed the bug was failing as expected.

image

Now it is passing after removing the conversion to str.

@jimwbaldwin
Copy link
Contributor Author

Static type checking looks fine after rebase.
image

@jimwbaldwin jimwbaldwin marked this pull request as ready for review November 5, 2024 00:57
@jimwbaldwin jimwbaldwin requested a review from vincbeck November 5, 2024 00:57
@gopidesupavan
Copy link
Member

LGTM :)

@gopidesupavan
Copy link
Member

@jimwbaldwin Nice one, BTW congrats on your first contribution :)

@jimwbaldwin
Copy link
Contributor Author

Still has static file checks issues. I'll check.

It was useful for demonstrating the bug but its not required
@vincbeck vincbeck merged commit f2dd350 into apache:main Nov 5, 2024
56 checks passed
Copy link

boring-cyborg bot commented Nov 5, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants