-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve GlueJobTrigger serialization bug causing verbose to always be True #43622
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
It doesn't test the functionality of what I wanted to test as it does not defer and thats where the bug is. Trying to figure out how to test something that has been deferred and then resumed. |
Some static check failures, please fix them |
Okay, I figured out how to find the bug we suspected and confirm it with a test. Please see the new
I'll take a look at these soon. |
serializing to a string makes True and False both true as any string is true
LGTM :) |
@jimwbaldwin Nice one, BTW congrats on your first contribution :) |
Still has static file checks issues. I'll check. |
It was useful for demonstrating the bug but its not required
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
related: #43620
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.