AIP-84 Migrate public xcom endpoint get entry to fastapi #43521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljs-c
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
michaeljs-c
force-pushed
the
migrate-xcom-getentry-to-fastapi
branch
from
b107d68 to
37e36a4
Compare
michaeljs-c
force-pushed
the
migrate-xcom-getentry-to-fastapi
branch
from
a48ad67 to
73a95e3
Compare
Thanks for the comments. I've updated the PR. It looks like adding the migration decorator caused CI to fail due to changes in the legacy API requiring a legacy tag? |
pierrejeambrun
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Minor change in how we define routes. TLDR we should not use async.
More info here #43797
I just pushed a commit to remove the async so we can merge.
Thanks again for your contribution. 🎉
pierrejeambrun
added
the
legacy api
|
@michaeljs-c Can you please rebase and solve conflicts, we are good to merge after that :) |
michaeljs-c
force-pushed
the
migrate-xcom-getentry-to-fastapi
branch
from
3a48142 to
0b2b68f
Compare
All done. Thanks @pierrejeambrun! |
pierrejeambrun
approved these changes
Nov 12, 2024
pierrejeambrun
changed the title
Merged
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 12, 2024
* Migrate public xcom get entry to fastapi * Update date parse call * add migration decorator, update params and test * Minor adjustment * Fix import and api spec --------- Co-authored-by: pierrejeambrun <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Migrate public xcom get entry to fastapi * Update date parse call * add migration decorator, update params and test * Minor adjustment * Fix import and api spec --------- Co-authored-by: pierrejeambrun <[email protected]>
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Migrate public xcom get entry to fastapi * Update date parse call * add migration decorator, update params and test * Minor adjustment * Fix import and api spec --------- Co-authored-by: pierrejeambrun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42978
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.