-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Migrate GET Dag Runs endpoint to FastAPI #43506
AIP-84 Migrate GET Dag Runs endpoint to FastAPI #43506
Conversation
d893747
to
05aa18e
Compare
…AIP-84/list_dag_runs
@pierrejeambrun , as of now get dag runs does not raise 404 not found if dag id is invalid. Link. Should we update it? |
I think we should update it in the new FastAPI endpoint, I wouldn't bother fixing the legacy one though (it's not really a bug, more of an imprecision I would say, we can live with that in airflow 2.x). We can do the same as in """Get tasks for DAG."""
dag: DAG = request.app.state.dag_bag.get_dag(dag_id)
if not dag:
raise HTTPException(status.HTTP_404_NOT_FOUND, f"Dag with id {dag_id} was not found") |
…AIP-84/list_dag_runs
…AIP-84/list_dag_runs
…AIP-84/list_dag_runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a really small tweak commit, ready to merge. (I didn't confirm my previous code review so the feedback never came through 🤦)
Thanks!
c2da15e
to
273a6d7
Compare
* add list_dag_runs * use logical_date * add tests * wip - writing tests * add tests * fix tests * Update airflow/api_fastapi/core_api/routes/public/dag_run.py * add status * Small tweak --------- Co-authored-by: pierrejeambrun <[email protected]>
* add list_dag_runs * use logical_date * add tests * wip - writing tests * add tests * fix tests * Update airflow/api_fastapi/core_api/routes/public/dag_run.py * add status * Small tweak --------- Co-authored-by: pierrejeambrun <[email protected]>
related to #42701