Ensure total_entries in /api/v1/dags #43377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i can't find the right place to write a unit test for this. any hints? |
🙏 |
|
Hello, Tests for this file are located in |
pierrejeambrun
added
the
legacy api
pierrejeambrun
approved these changes
Oct 28, 2024
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 28, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=... (cherry picked from commit 19ddb02)
pierrejeambrun
added a commit
that referenced
this pull request
Oct 30, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=... (cherry picked from commit 19ddb02) Co-authored-by: xitep <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=... (cherry picked from commit 19ddb02) Co-authored-by: xitep <[email protected]> (cherry picked from commit 6a23692)
utkarsharma2
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=... (cherry picked from commit 19ddb02) Co-authored-by: xitep <[email protected]> (cherry picked from commit 6a23692)
utkarsharma2
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=... (cherry picked from commit 19ddb02) Co-authored-by: xitep <[email protected]> (cherry picked from commit 6a23692)
utkarsharma2
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=... (cherry picked from commit 19ddb02) Co-authored-by: xitep <[email protected]> (cherry picked from commit 6a23692)
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Ensure total_entries in /api/v1/dags * Test total_entries for /api/v1/dags?fields=...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that "total_entries" is present in the API response of
/api/v1/dagseven if afieldsfilter is specified. Due to the enforced paging characteristic of the end-points, retrieving a field restricted response without a "total_entries" is of little use; this also aligns the behaviour with/api/v1/dags/~/dagRuns.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.