Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings when masking sensitive confs #43335

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 23, 2024

This is to prevent issues such as #43334 . This occurred when #43040 was merged. This PR fixes it.

Before:

root@131e2fda270d:/opt/airflow# airflow providers list
[2024-10-23T23:24:17.970+0000] {configuration.py:995} WARNING - section/key [core/asset_manager_kwargs] not found in config
[2024-10-23T23:24:17.971+0000] {configuration.py:995} WARNING - section/key [database/sql_alchemy_engine_args] not found in config
package_name                              | description                                                                                             | version
==========================================+=========================================================================================================+==========
apache-airflow-providers-airbyte          | Airbyte https://airbyte.com/                                                                            | 4.0.0
apache-airflow-providers-alibaba          | Alibaba Cloud integration (including Alibaba Cloud https://www.alibabacloud.com/)                       | 2.9.1

After:

root@131e2fda270d:/opt/airflow# airflow providers list
package_name                              | description                                                                                             | version
==========================================+=========================================================================================================+==========
apache-airflow-providers-airbyte          | Airbyte https://airbyte.com/                                                                            | 4.0.0
apache-airflow-providers-alibaba          | Alibaba Cloud integration (including Alibaba Cloud https://www.alibabacloud.com/)                       | 2.9.1

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil kaxil requested a review from potiuk October 23, 2024 23:26
@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

@potiuk here is why @suppress_logs_and_warning wasn't working

@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

Nice find @kaxil !

@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 23, 2024
@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

I am cherry-picking #43334 to (in #43336) - this one will also have to be cherry-picked.

@potiuk potiuk merged commit 0a9c3c0 into apache:main Oct 24, 2024
50 checks passed
potiuk pushed a commit to potiuk/airflow that referenced this pull request Oct 24, 2024
This is to prevent issues such as apache#43334

(cherry picked from commit 0a9c3c0)
@kaxil kaxil deleted the fix-warnings-cli branch October 24, 2024 00:13
potiuk added a commit that referenced this pull request Oct 24, 2024
This is to prevent issues such as #43334

(cherry picked from commit 0a9c3c0)

---------

Co-authored-by: Amogh Desai <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Oct 24, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
This is to prevent issues such as #43334

(cherry picked from commit 0a9c3c0)

---------

Co-authored-by: Amogh Desai <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants