Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Flask-AppBuilder to 4.5.2 #43309

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Bump Flask-AppBuilder to 4.5.2 #43309

merged 1 commit into from
Oct 23, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 23, 2024 •
edited
Loading

https://pypi.org/project/Flask-AppBuilder/4.5.2/ . It fixes WTForms issue mentioned in #43233. Fix was dpgaspar/Flask-AppBuilder#2279

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ashb
Copy link
Member

ashb commented Oct 23, 2024

This the WTForms fix?

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

This the WTForms fix?

Yup

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024 •
edited
Loading

This the WTForms fix?

Actually I will update the WTForms thing too

Done in 3459d4f

@kaxil kaxil force-pushed the bump-fab branch 2 times, most recently from 03ecedc to 3459d4f Compare October 23, 2024 12:56
@kaxil
Bump Flask-AppBuilder to 4.5.2
d3f6fcc 
https://pypi.org/project/Flask-AppBuilder/4.5.2/

# Conflicts:
#	dev/breeze/tests/test_packages.py
#	generated/provider_dependencies.json
#	providers/src/airflow/providers/fab/provider.yaml
@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

That was quick (from Daniel). But you will have to rebase @kaxil as I just merged 4.5.1 as it also had some "security manager" code changes - so we cannot go straight to 4.5.1 -> and now you have conflicts

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

That was quick (from Daniel). But you will have to rebase @kaxil as I just merged 4.5.1 as it also had some "security manager" code changes - so we cannot go straight to 4.5.1 -> and now you have conflicts

Done

@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 23, 2024
@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

Also we will need to backport this one to 2-10-test because of the wtforms limit removal

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024 •
edited
Loading

Also we will need to backport this one to 2-10-test because of the wtforms limit removal

Yup, will create a backport PR once this is merged

@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

I think due to our new backport policy, the number of PRs merged in Airflow increased significantly... But I am still increasing the lead @kaxil ;)

@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

But I am still increasing the lead @kaxil ;)

or NOT

image

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

I think due to our new backport policy, the number of PRs merged in Airflow increased significantly... But I am still increasing the lead @kaxil ;)

I need to change git author email and name on your laptop to mine :D

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

But I am still increasing the lead @kaxil ;)

or NOT

image

Let me be happy with the weekly ones :D

@jedcunningham jedcunningham mentioned this pull request Oct 23, 2024
Merged
@potiuk potiuk merged commit d7f50ba into apache:main Oct 23, 2024
108 checks passed
@kaxil kaxil deleted the bump-fab branch October 23, 2024 14:37
@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

Creating backport

@potiuk potiuk mentioned this pull request Oct 23, 2024
Merged
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 23, 2024
@kaxil
Backport: Bump Flask-AppBuilder to 4.5.2 (apache#43309)
d206440 
https://pypi.org/project/Flask-AppBuilder/4.5.2/

Backport of apache#43309
(cherry picked from commit d7f50ba)
@kaxil kaxil mentioned this pull request Oct 23, 2024
Merged
@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

Backport PR: #43318

kaxil added a commit to astronomer/airflow that referenced this pull request Oct 23, 2024
@kaxil
Backport: Bump Flask-AppBuilder to 4.5.2 (apache#43309)
d537a93 
https://pypi.org/project/Flask-AppBuilder/4.5.2/

Backport of apache#43309
(cherry picked from commit d7f50ba)
kaxil added a commit that referenced this pull request Oct 23, 2024
@kaxil
Backport: Bump Flask-AppBuilder to 4.5.2 (#43309) (#43318)
8b6a450
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@kaxil @harjeevanmaan
Bump Flask-AppBuilder to 4.5.2 (apache#43309)
1434a24 
https://pypi.org/project/Flask-AppBuilder/4.5.2/

# Conflicts:
#	dev/breeze/tests/test_packages.py
#	generated/provider_dependencies.json
#	providers/src/airflow/providers/fab/provider.yaml
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 24, 2024
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@kaxil @PaulKobow7536
Bump Flask-AppBuilder to 4.5.2 (apache#43309)
deadeb9 
https://pypi.org/project/Flask-AppBuilder/4.5.2/

# Conflicts:
#	dev/breeze/tests/test_packages.py
#	generated/provider_dependencies.json
#	providers/src/airflow/providers/fab/provider.yaml
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
@kaxil @utkarsharma2
Backport: Bump Flask-AppBuilder to 4.5.2 (#43309) (#43318)
4131ee0
@potiuk potiuk mentioned this pull request Oct 24, 2024
Closed
2 tasks
This was referenced Oct 27, 2024
Closed
Closed
Closed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@kaxil @ellisms
Bump Flask-AppBuilder to 4.5.2 (apache#43309)
de80462 
https://pypi.org/project/Flask-AppBuilder/4.5.2/

# Conflicts:
#	dev/breeze/tests/test_packages.py
#	generated/provider_dependencies.json
#	providers/src/airflow/providers/fab/provider.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedcunningham jedcunningham jedcunningham approved these changes

@shahar1 shahar1 shahar1 approved these changes

@Lee-W Lee-W Lee-W approved these changes

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees
No one assigned
Labels
area:dev-tools area:providers provider:fab type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 2.10.3
Development

Successfully merging this pull request may close these issues.
7 participants
@kaxil @ashb @potiuk @Lee-W @shahar1 @jedcunningham @utkarsharma2