-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade databricks provider dependency #43272
Upgrade databricks provider dependency #43272
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
53b14d2
to
97d12ea
Compare
4981110
to
817c01a
Compare
f8067c9
to
f372a8c
Compare
f372a8c
to
d26b588
Compare
just syncing my fork, but the manual checks were passing before this so I think this should be ready for review? |
53c3e9a
to
7daf6cf
Compare
Approved the workflow: 👀 |
bf65dff
to
c9bf287
Compare
sorry I think I needed to rebase again, there were quite a few test failures in the test_backfill_endpoint module, but I think not related to my changes, I do see it was removed in this PR: https://github.com/apache/airflow/pull/43649/files . Could you please help me trigger checks whenever you get chance again 🙇 CI run test failures: https://github.com/apache/airflow/actions/runs/11671655535/job/32506671351?pr=43272 |
924f052
to
175059d
Compare
e38e057
to
071f5ad
Compare
5dfa0f5
to
4886f4a
Compare
4886f4a
to
5acfa58
Compare
Still there seem to be databricks imports in snowflake ? |
5acfa58
to
35dbbdd
Compare
You need to rebase, rebuild image and it should work then. |
5d4ff25
to
96760ce
Compare
providers/src/airflow/providers/databricks/hooks/databricks_sql.py
Outdated
Show resolved
Hide resolved
33df396
to
fd8e10e
Compare
fd8e10e
to
e7fb0cc
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* update databricks-sql-connector to 3.0.0 for databricks provider * rename Row definition for no-redef error * fix: patches mypy errors for typing * fix: fixes static checks and moves Row import * fix: patches Row typing errors when databricks sql imported * remove databricks import from snowflake test module * introduce MockRow class for object comparison checks * Update providers/src/airflow/providers/databricks/hooks/databricks_sql.py --------- Co-authored-by: olharuban <[email protected]> Co-authored-by: Elad Kalif <[email protected]>
continuation of #42626
closes: #39274
suppress: #42626
patching some of the mypy test failures
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.