Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade databricks provider dependency #43272

Conversation

dcmshi
Copy link
Contributor

@dcmshi dcmshi commented Oct 22, 2024

continuation of #42626
closes: #39274
suppress: #42626
patching some of the mypy test failures


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 22, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 2 times, most recently from 53b14d2 to 97d12ea Compare October 28, 2024 15:31
@dcmshi
Copy link
Contributor Author

dcmshi commented Oct 28, 2024

provider checks are good locally

hatch run pre-commit run mypy-providers --all-files

Screenshot 2024-10-28 at 1 47 07 PM

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch from 4981110 to 817c01a Compare October 30, 2024 15:31
@dcmshi
Copy link
Contributor Author

dcmshi commented Oct 30, 2024

reran with manual mypy-providers check

hatch run pre-commit run --color always --verbose --hook-stage manual  mypy-providers --all-files
Screenshot 2024-10-30 at 11 31 15 AM

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 3 times, most recently from f8067c9 to f372a8c Compare November 1, 2024 15:17
@dcmshi dcmshi marked this pull request as ready for review November 1, 2024 15:17
@dcmshi dcmshi changed the title Dshi/upgrade databricks prodiver dependency version patch mypy upgrade databricks prodiver dependency version patch mypy Nov 1, 2024
@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch from f372a8c to d26b588 Compare November 1, 2024 19:39
@potiuk potiuk changed the title upgrade databricks prodiver dependency version patch mypy Upgrade databricks provideer dependency Nov 1, 2024
@potiuk potiuk changed the title Upgrade databricks provideer dependency Upgrade databricks provider dependency Nov 1, 2024
@dcmshi
Copy link
Contributor Author

dcmshi commented Nov 4, 2024

just syncing my fork, but the manual checks were passing before this so I think this should be ready for review?

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 2 times, most recently from 53c3e9a to 7daf6cf Compare November 4, 2024 19:54
@potiuk
Copy link
Member

potiuk commented Nov 4, 2024

Approved the workflow: 👀

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 2 times, most recently from bf65dff to c9bf287 Compare November 5, 2024 16:50
@dcmshi
Copy link
Contributor Author

dcmshi commented Nov 5, 2024

sorry I think I needed to rebase again, there were quite a few test failures in the test_backfill_endpoint module, but I think not related to my changes, I do see it was removed in this PR: https://github.com/apache/airflow/pull/43649/files . Could you please help me trigger checks whenever you get chance again 🙇

CI run test failures: https://github.com/apache/airflow/actions/runs/11671655535/job/32506671351?pr=43272
Screenshot 2024-11-05 at 11 48 25 AM

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 2 times, most recently from 924f052 to 175059d Compare November 5, 2024 19:31
@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 3 times, most recently from e38e057 to 071f5ad Compare November 8, 2024 16:00
@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 3 times, most recently from 5dfa0f5 to 4886f4a Compare November 15, 2024 15:34
@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch from 4886f4a to 5acfa58 Compare November 20, 2024 00:49
@potiuk
Copy link
Member

potiuk commented Nov 21, 2024

Still there seem to be databricks imports in snowflake ?

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch from 5acfa58 to 35dbbdd Compare November 22, 2024 02:25
@potiuk
Copy link
Member

potiuk commented Nov 22, 2024

You need to rebase, rebuild image and it should work then.

@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch 2 times, most recently from 5d4ff25 to 96760ce Compare November 26, 2024 04:36
@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch from 33df396 to fd8e10e Compare November 26, 2024 13:48
@dcmshi dcmshi force-pushed the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch from fd8e10e to e7fb0cc Compare November 26, 2024 14:20
@eladkal eladkal merged commit 0470bd9 into apache:main Nov 26, 2024
137 checks passed
Copy link

boring-cyborg bot commented Nov 26, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@dcmshi dcmshi deleted the dshi/upgrade_databricks_prodiver_dependency_version_patch_mypy branch November 27, 2024 04:34
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* update databricks-sql-connector to 3.0.0 for databricks provider

* rename Row definition for no-redef error

* fix: patches mypy errors for typing

* fix: fixes static checks and moves Row import

* fix: patches Row typing errors when databricks sql imported

* remove databricks import from snowflake test module

* introduce MockRow class for object comparison checks

* Update providers/src/airflow/providers/databricks/hooks/databricks_sql.py

---------

Co-authored-by: olharuban <[email protected]>
Co-authored-by: Elad Kalif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Databricks provider to depend on databricks-sql-connector >= 3.1.0
4 participants