Remove sqlalchemy-redshift dependency #43271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobuchowski
added
full tests needed
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:amazon
mobuchowski
changed the title
mobuchowski
force-pushed
the
remove-redshift-sqlalchemy
branch
from
dc73a32 to
7b9378b
Compare
`sqlalchemy-redshift` is unused. It is also not compatible with sqlalchemy>2, so good riddance!
mobuchowski
force-pushed
the
remove-redshift-sqlalchemy
branch
from
7b9378b to
a6f69c3
Compare
Signed-off-by: Maciej Obuchowski <[email protected]>
mobuchowski
force-pushed
the
remove-redshift-sqlalchemy
branch
from
a6f69c3 to
de20c51
Compare
mobuchowski
requested review from
potiuk,
ashb and
jedcunningham
as code owners
potiuk
approved these changes
Oct 23, 2024
|
Cool. @ashb you should be unblocked with this sqlalchemy 2 related dependency. One less for our "Airflow Beach Cleaning" to analyse as well. |
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* Remove sqlalchemy-redshift dependency from Amazon provider `sqlalchemy-redshift` is unused. It is also not compatible with sqlalchemy>2, so good riddance! * move redshift hook to use postgres connector Signed-off-by: Maciej Obuchowski <[email protected]> --------- Signed-off-by: Maciej Obuchowski <[email protected]> Co-authored-by: Ash Berlin-Taylor <[email protected]>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* Remove sqlalchemy-redshift dependency from Amazon provider `sqlalchemy-redshift` is unused. It is also not compatible with sqlalchemy>2, so good riddance! * move redshift hook to use postgres connector Signed-off-by: Maciej Obuchowski <[email protected]> --------- Signed-off-by: Maciej Obuchowski <[email protected]> Co-authored-by: Ash Berlin-Taylor <[email protected]>
This was referenced Oct 27, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Remove sqlalchemy-redshift dependency from Amazon provider `sqlalchemy-redshift` is unused. It is also not compatible with sqlalchemy>2, so good riddance! * move redshift hook to use postgres connector Signed-off-by: Maciej Obuchowski <[email protected]> --------- Signed-off-by: Maciej Obuchowski <[email protected]> Co-authored-by: Ash Berlin-Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this manually, should work - let's look at the tests.