Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instruction for docker compose(tested on Mac M1) #43119

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

Udbv
Copy link
Contributor

@Udbv Udbv commented Oct 17, 2024

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 17, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!
I ran a small fix for static checks.

@Udbv
Copy link
Contributor Author

Udbv commented Oct 18, 2024

Thanks, @potiuk @shahar1 Seems like I fixed linter issue

Udbv and others added 3 commits October 23, 2024 16:56
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1 shahar1 force-pushed the docs/fix_docker_compose_how_to branch from c3f70fb to 9f1bf9d Compare October 23, 2024 14:20
@shahar1 shahar1 added this to the Airflow 2.10.3 milestone Oct 23, 2024
@shahar1 shahar1 merged commit d725cf6 into apache:main Oct 23, 2024
42 checks passed
Copy link

boring-cyborg bot commented Oct 23, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

shahar1 pushed a commit to shahar1/airflow that referenced this pull request Oct 23, 2024
* Fix instruction for docker compose(tested on Mac M1)

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

* fix static checks

* fix linter error

* fix unexpected identation

---------

Co-authored-by: Shahar Epstein <[email protected]>
(cherry picked from commit d725cf6)
kaxil pushed a commit that referenced this pull request Oct 23, 2024
* Fix instruction for docker compose(tested on Mac M1)

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

* fix static checks

* fix linter error

* fix unexpected identation

---------

Co-authored-by: Shahar Epstein <[email protected]>
(cherry picked from commit d725cf6)

Co-authored-by: Bohdan Udovenko <[email protected]>
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
* Fix instruction for docker compose(tested on Mac M1)

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

* fix static checks

* fix linter error

* fix unexpected identation

---------

Co-authored-by: Shahar Epstein <[email protected]>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
* Fix instruction for docker compose(tested on Mac M1)

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

* fix static checks

* fix linter error

* fix unexpected identation

---------

Co-authored-by: Shahar Epstein <[email protected]>
@utkarsharma2 utkarsharma2 added the type:doc-only Changelog: Doc Only label Oct 24, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
* Fix instruction for docker compose(tested on Mac M1)

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

* fix static checks

* fix linter error

* fix unexpected identation

---------

Co-authored-by: Shahar Epstein <[email protected]>
(cherry picked from commit d725cf6)

Co-authored-by: Bohdan Udovenko <[email protected]>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Fix instruction for docker compose(tested on Mac M1)

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

* fix static checks

* fix linter error

* fix unexpected identation

---------

Co-authored-by: Shahar Epstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants