Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added task_instance_mutation_hook for mapped operator index 0 (#42661) #43089

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Added task_instance_mutation_hook for mapped operator index 0 (#42661) #43089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airflow/models/abstractoperator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,8 @@ def expand_mapped_task(self, run_id: str, *, session: Session) -> tuple[Sequence
unmapped_ti.map_index = 0
self.log.debug("Updated in place to become %s", unmapped_ti)
all_expanded_tis.append(unmapped_ti)
# execute hook for task instance map index 0
task_instance_mutation_hook(unmapped_ti)
session.flush()
else:
self.log.debug("Deleting the original task instance: %s", unmapped_ti)
Expand Down
25 changes: 25 additions & 0 deletions tests/models/test_mappedoperator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from collections import defaultdict
from datetime import timedelta
from typing import TYPE_CHECKING
from unittest import mock
from unittest.mock import patch

import pendulum
Expand Down Expand Up @@ -716,6 +717,30 @@ def test_expand_mapped_task_instance_with_named_index(
assert indices == expected_rendered_names


@pytest.mark.parametrize(
"create_mapped_task",
[
pytest.param(_create_mapped_with_name_template_classic, id="classic"),
pytest.param(_create_mapped_with_name_template_taskflow, id="taskflow"),
],
)
def test_expand_mapped_task_task_instance_mutation_hook(dag_maker, session, create_mapped_task) -> None:
"""Test that the tast_instance_mutation_hook is called."""
expected_map_index = [0, 1, 2]

with dag_maker(session=session):
task1 = BaseOperator(task_id="op1")
mapped = MockOperator.partial(task_id="task_2").expand(arg2=task1.output)

dr = dag_maker.create_dagrun()

with mock.patch("airflow.settings.task_instance_mutation_hook") as mock_hook:
expand_mapped_task(mapped, dr.run_id, task1.task_id, length=len(expected_map_index), session=session)

for index, call in enumerate(mock_hook.call_args_list):
assert call.args[0].map_index == expected_map_index[index]


@pytest.mark.skip_if_database_isolation_mode # Does not work in db isolation mode
@pytest.mark.parametrize(
"map_index, expected",
Expand Down