-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable flaky mssql based integration tests #42811
Conversation
Actualyt now, when I think of it - quarantining is not enough /not needed - what we really need is to not have mssql integration running in CI. If you look at selective checks -> they produce the list of "testable_integrations" : https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1298 Defined here: This list is produced by selective checks here: And used in the workflow that runs integration tests to produce matrix of jobs: https://github.com/apache/airflow/blob/main/.github/workflows/integration-tests.yml#L67 So all we need to do is to remove mssql from the list. This is actually cool - because this way you can still run the tests locally:
but they will not run in CI. |
yeah, your correct. that was great suggestion, let me check and update. thank you |
@potiuk if i remove mssql from TESTABLE_INTEGRATIONS and running breeze command in local, its failing , because the command validation failing at
So i have added new constant to disable not required integrations. hope that is fine? ![]() |
1cc7cc2
to
6534ade
Compare
@gopidesupavan -> maybe we can cherry-pick that on to v2-10-test as well. |
* quarantined flaky mssql integration tests * disable mssql from ci integration checks
Sure i will get these. |
* quarantined flaky mssql integration tests * disable mssql from ci integration checks
* quarantined flaky mssql integration tests * disable mssql from ci integration checks
* quarantined flaky mssql integration tests * disable mssql from ci integration checks
* quarantined flaky mssql integration tests * disable mssql from ci integration checks
* quarantined flaky mssql integration tests * disable mssql from ci integration checks
Currently in CI these tests are failing with
pymssql.exceptions.OperationalError:
. as discussed in slack ci-cd group , disabling these tests.https://github.com/apache/airflow/actions/runs/11210718014/job/31158453211#step:6:2844
tests/integration/providers/microsoft/mssql/hooks/test_mssql.py::TestMsSqlHook
tests/integration/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer
tests/integration/providers/google/cloud/transfers/test_bigquery_to_mssql.py::TestBigQueryToMsSqlOperator
tests/integration/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator
hope
@pytest.mark.quarantined
works?^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.