Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky mssql based integration tests #42811

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

gopidesupavan
Copy link
Member

Currently in CI these tests are failing with pymssql.exceptions.OperationalError: . as discussed in slack ci-cd group , disabling these tests.

https://github.com/apache/airflow/actions/runs/11210718014/job/31158453211#step:6:2844

tests/integration/providers/microsoft/mssql/hooks/test_mssql.py::TestMsSqlHook
tests/integration/providers/apache/hive/transfers/test_mssql_to_hive.py::TestMsSqlToHiveTransfer
tests/integration/providers/google/cloud/transfers/test_bigquery_to_mssql.py::TestBigQueryToMsSqlOperator
tests/integration/providers/google/cloud/transfers/test_mssql_to_gcs.py::TestMsSqlToGoogleCloudStorageOperator

hope @pytest.mark.quarantined works?


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Oct 8, 2024

Actualyt now, when I think of it - quarantining is not enough /not needed - what we really need is to not have mssql integration running in CI.

If you look at selective checks -> they produce the list of "testable_integrations" : https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1298

Defined here:

https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/global_constants.py#L57

This list is produced by selective checks here:

https://github.com/apache/airflow/actions/runs/11226083287/job/31205948119?pr=42811#step:8:824

And used in the workflow that runs integration tests to produce matrix of jobs:

https://github.com/apache/airflow/blob/main/.github/workflows/integration-tests.yml#L67

So all we need to do is to remove mssql from the list.

This is actually cool - because this way you can still run the tests locally:

breeze tessting integration-tests --integration mssql 

but they will not run in CI.

@gopidesupavan
Copy link
Member Author

Actualyt now, when I think of it - quarantining is not enough /not needed - what we really need is to not have mssql integration running in CI.

If you look at selective checks -> they produce the list of "testable_integrations" : https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1298

Defined here:

https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/global_constants.py#L57

This list is produced by selective checks here:

https://github.com/apache/airflow/actions/runs/11226083287/job/31205948119?pr=42811#step:8:824

And used in the workflow that runs integration tests to produce matrix of jobs:

https://github.com/apache/airflow/blob/main/.github/workflows/integration-tests.yml#L67

So all we need to do is to remove mssql from the list.

This is actually cool - because this way you can still run the tests locally:

breeze tessting integration-tests --integration mssql 

but they will not run in CI.

yeah, your correct. that was great suggestion, let me check and update. thank you

@gopidesupavan
Copy link
Member Author

@potiuk if i remove mssql from TESTABLE_INTEGRATIONS and running breeze command in local, its failing , because the command validation failing at BetterChoice.

option_integration = click.option( "--integration", help="Integration(s) to enable when running (can be more than one).", type=BetterChoice(AUTOCOMPLETE_INTEGRATIONS), multiple=True, )

So i have added new constant to disable not required integrations. hope that is fine?

image

@potiuk potiuk merged commit 20f8290 into apache:main Oct 13, 2024
80 checks passed
@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 13, 2024
@potiuk
Copy link
Member

potiuk commented Oct 13, 2024

@gopidesupavan -> maybe we can cherry-pick that on to v2-10-test as well.

pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
@gopidesupavan
Copy link
Member Author

@gopidesupavan -> maybe we can cherry-pick that on to v2-10-test as well.

Sure i will get these.

gopidesupavan added a commit to gopidesupavan/airflow that referenced this pull request Oct 14, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
potiuk pushed a commit that referenced this pull request Oct 15, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* quarantined flaky mssql integration tests

* disable mssql from ci integration checks
@gopidesupavan gopidesupavan deleted the disable-flaky-tests branch November 23, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants