Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added task_instance_mutation_hook for mapped operator index 0 #42661

Conversation

AutomationDev85
Copy link
Contributor

During working with the task instance mutation hook feature I found an Issue with the execution of the hook and the mapped operator. The Hook was only executed for the expanded tasks index > 0 and the Index 0 was not executed with the hook.

This PR adds call of task_instance_mutation_hook if the index 0 does not exists in the DB.

@jscheffl jscheffl self-assigned this Oct 7, 2024
@jscheffl jscheffl added this to the Airflow 2.10.3 milestone Oct 7, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. Besides the comment - can you please also add a unit test for the feature to ensure a regression is prevented if code is re-worked?

airflow/models/abstractoperator.py Show resolved Hide resolved
@jscheffl jscheffl merged commit b7007e2 into apache:main Oct 16, 2024
51 checks passed
jscheffl pushed a commit to jscheffl/airflow that referenced this pull request Oct 16, 2024
…#42661)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
(cherry picked from commit b7007e2)
romsharon98 pushed a commit that referenced this pull request Oct 16, 2024
#43089)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
(cherry picked from commit b7007e2)

Co-authored-by: AutomationDev85 <[email protected]>
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
…#42661)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
#43089)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
(cherry picked from commit b7007e2)

Co-authored-by: AutomationDev85 <[email protected]>
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
…#42661)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
…#42661)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
#43089)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
(cherry picked from commit b7007e2)

Co-authored-by: AutomationDev85 <[email protected]>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…#42661)

* Added task_instance_mutation_hook for mapped operator index 0

* Added unit test

---------

Co-authored-by: Marco Küttelwesch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants