-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added task_instance_mutation_hook for mapped operator index 0 #42661
Merged
jscheffl
merged 2 commits into
apache:main
from
boschglobal:bugfix/enable-task-mutation-hook-for-mapped-operator-index-0
Oct 16, 2024
Merged
Added task_instance_mutation_hook for mapped operator index 0 #42661
jscheffl
merged 2 commits into
apache:main
from
boschglobal:bugfix/enable-task-mutation-hook-for-mapped-operator-index-0
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement. Besides the comment - can you please also add a unit test for the feature to ensure a regression is prevented if code is re-worked?
jscheffl
approved these changes
Oct 16, 2024
jscheffl
approved these changes
Oct 16, 2024
jscheffl
pushed a commit
to jscheffl/airflow
that referenced
this pull request
Oct 16, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]> (cherry picked from commit b7007e2)
romsharon98
pushed a commit
that referenced
this pull request
Oct 16, 2024
#43089) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]> (cherry picked from commit b7007e2) Co-authored-by: AutomationDev85 <[email protected]>
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
#43089) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]> (cherry picked from commit b7007e2) Co-authored-by: AutomationDev85 <[email protected]>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
#43089) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]> (cherry picked from commit b7007e2) Co-authored-by: AutomationDev85 <[email protected]>
This was referenced Oct 28, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During working with the task instance mutation hook feature I found an Issue with the execution of the hook and the mapped operator. The Hook was only executed for the expanded tasks index > 0 and the Index 0 was not executed with the hook.
This PR adds call of task_instance_mutation_hook if the index 0 does not exists in the DB.