Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Add retry logic in the scheduler for updating trigger timeouts in case of deadlocks. (#41429) #42651

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

shahar1
Copy link
Contributor

@shahar1 shahar1 commented Oct 2, 2024

backports: #41429

(cherry picked from commit 00589cf)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…e of deadlocks. (apache#41429)

* Add retry in update trigger timeout

* add ut for these cases

* use OperationalError in ut to describe deadlock scenarios

* [MINOR] add newsfragment for this PR

* [MINOR] refactor UT for mypy check

(cherry picked from commit 00589cf)
@shahar1 shahar1 requested review from kaxil, ashb and XD-DENG as code owners October 2, 2024 06:54
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Oct 2, 2024
@shahar1
Copy link
Contributor Author

shahar1 commented Oct 2, 2024

Checking regarding the mypy errors.
Edit: backporting #42656 should fix it.

@shahar1 shahar1 requested a review from Lee-W October 2, 2024 08:49
@shahar1 shahar1 merged commit fcbf6fe into apache:v2-10-test Oct 2, 2024
49 checks passed
@jscheffl jscheffl added this to the Airflow 2.10.3 milestone Oct 2, 2024
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
…outs in case of deadlocks. (#41429) (#42651)

* Add retry logic in the scheduler for updating trigger timeouts in case of deadlocks. (#41429)

* Add retry in update trigger timeout

* add ut for these cases

* use OperationalError in ut to describe deadlock scenarios

* [MINOR] add newsfragment for this PR

* [MINOR] refactor UT for mypy check

(cherry picked from commit 00589cf)

* Fix type-ignore comment for typing changes (#42656)

---------

Co-authored-by: TakawaAkirayo <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
…outs in case of deadlocks. (#41429) (#42651)

* Add retry logic in the scheduler for updating trigger timeouts in case of deadlocks. (#41429)

* Add retry in update trigger timeout

* add ut for these cases

* use OperationalError in ut to describe deadlock scenarios

* [MINOR] add newsfragment for this PR

* [MINOR] refactor UT for mypy check

(cherry picked from commit 00589cf)

* Fix type-ignore comment for typing changes (#42656)

---------

Co-authored-by: TakawaAkirayo <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants