Rename dataset endpoints as asset endpoints #42579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
Lee-W
force-pushed
the
rename-dataset-as-asset-api
branch
9 times, most recently
from
5af121f to
6b170e0
Compare
uranusjr
reviewed
Oct 2, 2024
Lee-W
force-pushed
the
rename-dataset-as-asset-api
branch
2 times, most recently
from
6be206a to
beba573
Compare
Lee-W
changed the title
Lee-W
force-pushed
the
rename-dataset-as-asset-api
branch
from
beba573 to
159e7e8
Compare
Lee-W
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl,
ashb and
ephraimbuddy
as code owners
vincbeck
reviewed
Oct 2, 2024
Lee-W
force-pushed
the
rename-dataset-as-asset-api
branch
from
159e7e8 to
72d3df2
Compare
bbovenzi
reviewed
Oct 3, 2024
bbovenzi
reviewed
Oct 3, 2024
bbovenzi
reviewed
Oct 3, 2024
Lee-W
force-pushed
the
rename-dataset-as-asset-api
branch
from
72d3df2 to
d6054ba
Compare
bbovenzi
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Functionality lgtm
There's still variable names and places in the UI that use the name "dataset". But it is all deprecated so that's fine by me. Once we upgrade the db columns, let's make sure no mention of dataset finds its way into /api_fastapi and /ui directories.
Sure! The next PR I'll work on is the DB one. once that's merged, I think we can get rid of the dataset in |
vincbeck
approved these changes
Oct 3, 2024
|
Assuming post-merge this PR broke canary tests on main - can you take a look for fixing? https://github.com/apache/airflow/actions/runs/11175856695/job/31068286744 |
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* feat(api_connexion): rename dataset_endpoint module as asset_endpoint * feat(api_connexion/openapi): rename tag Dataset as Asset * feat(api_connexion): rename create_dataset_event as create_asset_event * feat(api_connexion): rename schema CreateDatasetEvent as CreateAssetEvent * test(api_connexion): rename test_dataset_endpoint as test_asset_endpoint * feat(api_connexion): rename delete_dataset_queued_events as delete_asset_queued_events * feat(api_connexion): rename get_dataset_queued_events as get_asset_queued_events * feat(api_connexion): rename delete_dag_dataset_queued_events as delete_dag_asset_queued_events * feat(api_connexion): rename delete_dag_dataset_queued_event as delete_dag_asset_queued_event * feat(api_connexion): rename get_dag_dataset_queued_events as get_dag_asset_queued_events * feat(api_connexion): rename get_dag_dataset_queued_event as get_dag_asset_queued_event * refactor(api_connexion): remove unused dataset_id in _generate_queued_event_where_clause * feat(api_connexion): rename get_dataset_events as get_asset_events * feat(api_connexion): rename get_datasets as get_assets * feat(api_connexion): rename get_dataset as get_asset * feat(api_connexion/openapi): update api docs * feat(js): rename DatasetEvents as AssetEvents * feat(js): rename DatasetDetails as AssetDetails * feat(js): rename DatasetList as AssetList * feat(js/api): rename useUpstreamDatasetEvents as useUpstreamAssetEvents * feat(js/api): rename useDatasetsSummary as useAssetsSummary * feat(js/api): rename useDatasetDependencies as useAssetDependencies * feat(js/api): rename useDatasetEvents as useAssetEvents * feat(js/api): rename useDatasets as useAssets * feat(js/api): rename useDataset as useAsset * feat(api_connexion): rename get_upstream_dataset_events as get_upstream_asset_events * feat(api_connexion/openapi/v1): rename DatasetURI as AssetURI * feat(api_connexion/openapi/v1): rename DatasetCollection as AssetCollection * feat(api_connexion/openapi/v1): rename DagScheduleDatasetReference as DagScheduleAssetReference * feat(api_connexion/openapi/v1): rename TaskOutletDatasetReference as TaskOutletAssetReference * feat(js/api): rename DatasetEventCollection as AssetEventCollection * feat(api_connexion/openapi/v1): rename DatasetEvent as AssetEvent * feat(api_connexion/openapi/v1): rename Dataset as Asset * docs(api_connexion/openapi/v1): update dataset to asset in v1.yaml * feat(api_connexion): rename endpoint datasets as assets * test(api_connexion): rename dataset as asset * fix(api_connexion/openapi/v1): fix queued_events property name error * feat(api_fastapi): rename next_run_datasets as next_run_assets * test: resolve test conflict * docs(newsfragments): add newsfragments for dataset to asset endpoint rename * feat(js/api): rename datasetEvents as assetEvents * feat(js/api): rename variable datasetEvent as assetEvent * feat(js/api): rename dataset_api as asset_api
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* feat(api_connexion): rename dataset_endpoint module as asset_endpoint * feat(api_connexion/openapi): rename tag Dataset as Asset * feat(api_connexion): rename create_dataset_event as create_asset_event * feat(api_connexion): rename schema CreateDatasetEvent as CreateAssetEvent * test(api_connexion): rename test_dataset_endpoint as test_asset_endpoint * feat(api_connexion): rename delete_dataset_queued_events as delete_asset_queued_events * feat(api_connexion): rename get_dataset_queued_events as get_asset_queued_events * feat(api_connexion): rename delete_dag_dataset_queued_events as delete_dag_asset_queued_events * feat(api_connexion): rename delete_dag_dataset_queued_event as delete_dag_asset_queued_event * feat(api_connexion): rename get_dag_dataset_queued_events as get_dag_asset_queued_events * feat(api_connexion): rename get_dag_dataset_queued_event as get_dag_asset_queued_event * refactor(api_connexion): remove unused dataset_id in _generate_queued_event_where_clause * feat(api_connexion): rename get_dataset_events as get_asset_events * feat(api_connexion): rename get_datasets as get_assets * feat(api_connexion): rename get_dataset as get_asset * feat(api_connexion/openapi): update api docs * feat(js): rename DatasetEvents as AssetEvents * feat(js): rename DatasetDetails as AssetDetails * feat(js): rename DatasetList as AssetList * feat(js/api): rename useUpstreamDatasetEvents as useUpstreamAssetEvents * feat(js/api): rename useDatasetsSummary as useAssetsSummary * feat(js/api): rename useDatasetDependencies as useAssetDependencies * feat(js/api): rename useDatasetEvents as useAssetEvents * feat(js/api): rename useDatasets as useAssets * feat(js/api): rename useDataset as useAsset * feat(api_connexion): rename get_upstream_dataset_events as get_upstream_asset_events * feat(api_connexion/openapi/v1): rename DatasetURI as AssetURI * feat(api_connexion/openapi/v1): rename DatasetCollection as AssetCollection * feat(api_connexion/openapi/v1): rename DagScheduleDatasetReference as DagScheduleAssetReference * feat(api_connexion/openapi/v1): rename TaskOutletDatasetReference as TaskOutletAssetReference * feat(js/api): rename DatasetEventCollection as AssetEventCollection * feat(api_connexion/openapi/v1): rename DatasetEvent as AssetEvent * feat(api_connexion/openapi/v1): rename Dataset as Asset * docs(api_connexion/openapi/v1): update dataset to asset in v1.yaml * feat(api_connexion): rename endpoint datasets as assets * test(api_connexion): rename dataset as asset * fix(api_connexion/openapi/v1): fix queued_events property name error * feat(api_fastapi): rename next_run_datasets as next_run_assets * test: resolve test conflict * docs(newsfragments): add newsfragments for dataset to asset endpoint rename * feat(js/api): rename datasetEvents as assetEvents * feat(js/api): rename variable datasetEvent as assetEvent * feat(js/api): rename dataset_api as asset_api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/datasetsas/assets/datasets/{uri}as/assets/{uri}/datasets/eventsas/assets/events/datasets/queuedEvent/{uri}as/ui/next_run_assets/upstream/dags/{dag_id}/dagRuns/{dag_run_id}/upstreamDatasetEventsas/ui/next_run_assets/upstream/dags/{dag_id}/datasets/queuedEvent/{uri}as/ui/next_run_assets/upstream/dags/{dag_id}/datasets/queuedEventas/ui/next_run_assets/upstream/ui/next_run_datasets/upstreamas/ui/next_run_assets/upstreamAssetCollection.datasetsasAssetCollection.assetsAssetEventCollection.dataset_eventsasAssetEventCollection.asset_eventsAssetEventCollectionSchema.dataset_eventsasAssetEventCollectionSchema.asset_eventsCreateAssetEventSchema.dataset_uriasCreateAssetEventSchema.asset_uriSome of the names are still kept as Dataset due to the database not being changed. will be handled in #42023
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.