-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce eyestrain in dark mode with reduced contrast and saturation #42567
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Can you (please) add a screenshot to the description to before and after for the reviewers? Note that actually the UI is currently re-workerd and gets a totally different dark-mode in Airflow 3.0. In Airflow 2 we actually only want to make bug fixes. No new features. So we would need to classify this as bug fix? @bbovenzi WDYT? |
Understand that this is considered an experimental feature and likely will be be deprecated up the next major release. Until then, I figured that there might be some teams out there that would appreciate this subtle, yet effective styling update. I've added screenshots to the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do another patch release, then I'm happy to include this as a bug fix.
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…pache#42567) * reduce eyestrain in dark mode with reduced contrast and saturation * feat: readjusted saturation --------- Co-authored-by: Curtis Bangert <[email protected]> (cherry picked from commit 97c7d2c)
…42567) (#42583) * reduce eyestrain in dark mode with reduced contrast and saturation * feat: readjusted saturation --------- Co-authored-by: Curtis Bangert <[email protected]> (cherry picked from commit 97c7d2c) Co-authored-by: codecae <[email protected]>
Nice. That was also bothering me. |
…pache#42567) * reduce eyestrain in dark mode with reduced contrast and saturation * feat: readjusted saturation --------- Co-authored-by: Curtis Bangert <[email protected]>
…42567) (#42583) * reduce eyestrain in dark mode with reduced contrast and saturation * feat: readjusted saturation --------- Co-authored-by: Curtis Bangert <[email protected]> (cherry picked from commit 97c7d2c) Co-authored-by: codecae <[email protected]>
…42567) (#42583) * reduce eyestrain in dark mode with reduced contrast and saturation * feat: readjusted saturation --------- Co-authored-by: Curtis Bangert <[email protected]> (cherry picked from commit 97c7d2c) Co-authored-by: codecae <[email protected]>
…pache#42567) * reduce eyestrain in dark mode with reduced contrast and saturation * feat: readjusted saturation --------- Co-authored-by: Curtis Bangert <[email protected]>
While the new dark mode is very appreciated, the inversion and 180 degree hue rotation creates a harsh contrast that some people find a bit extreme and uncomfortable. This change simply lowers the saturation and contrast to soften the overall appearance, potentially reducing eyestrain for people with eyes that are sensitive to such high contrast.
Adjusting the contrast also emphasizes the styling between alternating rows in the DAG list.
Open to suggestions to better tweak it for a broader audience.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.