Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce eyestrain in dark mode with reduced contrast and saturation #42567

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

codecae
Copy link
Contributor

@codecae codecae commented Sep 29, 2024

While the new dark mode is very appreciated, the inversion and 180 degree hue rotation creates a harsh contrast that some people find a bit extreme and uncomfortable. This change simply lowers the saturation and contrast to soften the overall appearance, potentially reducing eyestrain for people with eyes that are sensitive to such high contrast.

Adjusting the contrast also emphasizes the styling between alternating rows in the DAG list.

Open to suggestions to better tweak it for a broader audience.

Before:
airflowbefore
airflowbefore

After:
image
airflowafter


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 29, 2024
Copy link

boring-cyborg bot commented Sep 29, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@jscheffl
Copy link
Contributor

jscheffl commented Sep 29, 2024

Can you (please) add a screenshot to the description to before and after for the reviewers?

Note that actually the UI is currently re-workerd and gets a totally different dark-mode in Airflow 3.0. In Airflow 2 we actually only want to make bug fixes. No new features. So we would need to classify this as bug fix? @bbovenzi WDYT?

@codecae
Copy link
Contributor Author

codecae commented Sep 30, 2024

Can you (please) add a screenshot to the description to before and after for the reviewers?

Note that actually the UI is currently re-workerd and gets a totally different dark-mode in Airflow 3.0. In Airflow 2 we actually only want to make bug fixes. No new features. So we would need to classify this as bug fix? @bbovenzi WDYT?

Understand that this is considered an experimental feature and likely will be be deprecated up the next major release. Until then, I figured that there might be some teams out there that would appreciate this subtle, yet effective styling update.

I've added screenshots to the description.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do another patch release, then I'm happy to include this as a bug fix.

@codecae
Copy link
Contributor Author

codecae commented Sep 30, 2024

Thanks for the approval @bbovenzi !

Speaking of 3.0 UI updates -- Does anyone know if #35301 will be addressed in 3.0? It makes the graph view pretty much a rats nest on large dags.

@pierrejeambrun pierrejeambrun merged commit 97c7d2c into apache:main Sep 30, 2024
53 checks passed
Copy link

boring-cyborg bot commented Sep 30, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Sep 30, 2024
pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Sep 30, 2024
…pache#42567)

* reduce eyestrain in dark mode with reduced contrast and saturation

* feat: readjusted saturation

---------

Co-authored-by: Curtis Bangert <[email protected]>
(cherry picked from commit 97c7d2c)
bbovenzi pushed a commit that referenced this pull request Sep 30, 2024
…42567) (#42583)

* reduce eyestrain in dark mode with reduced contrast and saturation

* feat: readjusted saturation

---------

Co-authored-by: Curtis Bangert <[email protected]>
(cherry picked from commit 97c7d2c)

Co-authored-by: codecae <[email protected]>
@potiuk
Copy link
Member

potiuk commented Oct 2, 2024

Nice. That was also bothering me.

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
…pache#42567)

* reduce eyestrain in dark mode with reduced contrast and saturation

* feat: readjusted saturation

---------

Co-authored-by: Curtis Bangert <[email protected]>
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.3 milestone Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
…42567) (#42583)

* reduce eyestrain in dark mode with reduced contrast and saturation

* feat: readjusted saturation

---------

Co-authored-by: Curtis Bangert <[email protected]>
(cherry picked from commit 97c7d2c)

Co-authored-by: codecae <[email protected]>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
…42567) (#42583)

* reduce eyestrain in dark mode with reduced contrast and saturation

* feat: readjusted saturation

---------

Co-authored-by: Curtis Bangert <[email protected]>
(cherry picked from commit 97c7d2c)

Co-authored-by: codecae <[email protected]>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…pache#42567)

* reduce eyestrain in dark mode with reduced contrast and saturation

* feat: readjusted saturation

---------

Co-authored-by: Curtis Bangert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants