Handle ENTER key correctly in trigger form and allow manual JSON #42525
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
jscheffl
added
type:bug-fix
Taking a look |
|
@jscheffl tested your branch locally, works good for me. Thank you! |
shahar1
approved these changes
Sep 27, 2024
pierrejeambrun
approved these changes
Sep 27, 2024
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 27, 2024
…che#42525) (cherry picked from commit 3ef29a6)
|
Thanks, cherrypick PR is here #42535 |
shahar1
pushed a commit
that referenced
this pull request
Sep 27, 2024
) (#42535) (cherry picked from commit 3ef29a6) Co-authored-by: Jens Scheffler <[email protected]>
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
) (#42535) (cherry picked from commit 3ef29a6) Co-authored-by: Jens Scheffler <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
) (#42535) (cherry picked from commit 3ef29a6) Co-authored-by: Jens Scheffler <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #42487
related: #42157
Unfortunately a bit more JavaScript is needed but this enables:
@dannyl1u - can you confirm from your side?