Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Doc update - Airflow local settings no longer importable from dags folder #42231

Merged
merged 8 commits into from
Oct 1, 2024
Merged

FIX: Doc update - Airflow local settings no longer importable from dags folder #42231

merged 8 commits into from
Oct 1, 2024

Conversation

jishangarg
Copy link
Contributor

@jishangarg jishangarg commented Sep 14, 2024 •
edited
Loading

closes: #42156
related: #42156

jigarg and others added 6 commits September 14, 2024 05:59
@jigarg
doc changed
42aaa9f
@jigarg
note
bb4bcc8
@jigarg
improve
a6d22dd
@jigarg
improve
4f1790b
@jigarg
remove newline
e96fc7d
@jishangarg
Merge pull request #1 from jishangarg/fix_doc
f8a8a34 
FIX: Doc updated - Airflow local settings no longer importable from dags folder
@jishangarg jishangarg requested a review from potiuk as a code owner September 14, 2024 00:57
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Sep 14, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@jishangarg
Copy link
Contributor Author

can anyone please review?

@shahar1 shahar1 added this to the Airflow 2.10.2 milestone Sep 15, 2024
@potiuk potiuk merged commit f4f38f1 into apache:main Oct 1, 2024
40 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Oct 1, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

potiuk pushed a commit to potiuk/airflow that referenced this pull request Oct 1, 2024
@jishangarg @potiuk
Doc update - Airflow local settings no longer importable from dags fo…
7e4ff17 
…lder (apache#42231)

---------

Co-authored-by: Jishan Garg <[email protected]>
(cherry picked from commit f4f38f1)
@potiuk potiuk mentioned this pull request Oct 1, 2024
Merged
potiuk added a commit that referenced this pull request Oct 1, 2024
@potiuk @jishangarg
Doc update - Airflow local settings no longer importable from dags fo…
0668402 
…lder (#42231) (#42603)

---------

Co-authored-by: Jishan Garg <[email protected]>
(cherry picked from commit f4f38f1)

Co-authored-by: JISHAN GARGACHARYA <[email protected]>
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@jishangarg @jigarg @joaopamaral
Doc update - Airflow local settings no longer importable from dags fo…
7ead4e8 
…lder (apache#42231)



---------

Co-authored-by: Jishan Garg <[email protected]>
@utkarsharma2 utkarsharma2 added the type:doc-only Changelog: Doc Only label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
@potiuk @jishangarg @utkarsharma2
Doc update - Airflow local settings no longer importable from dags fo…
17b67c1 
…lder (#42231) (#42603)

---------

Co-authored-by: Jishan Garg <[email protected]>
(cherry picked from commit f4f38f1)

Co-authored-by: JISHAN GARGACHARYA <[email protected]>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
@potiuk @jishangarg @utkarsharma2
Doc update - Airflow local settings no longer importable from dags fo…
4b24e81 
…lder (#42231) (#42603)

---------

Co-authored-by: Jishan Garg <[email protected]>
(cherry picked from commit f4f38f1)

Co-authored-by: JISHAN GARGACHARYA <[email protected]>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@jishangarg @jigarg @ellisms
Doc update - Airflow local settings no longer importable from dags fo…
174ea47 
…lder (apache#42231)



---------

Co-authored-by: Jishan Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal left review comments

@romsharon98 romsharon98 romsharon98 approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees
No one assigned
Labels
kind:documentation type:doc-only Changelog: Doc Only
Projects
None yet
Milestone
Airflow 2.10.3
Development

Successfully merging this pull request may close these issues.

Airflow local settings no longer importable from dags folder
8 participants
@jishangarg @romsharon98 @eladkal @potiuk @ephraimbuddy @utkarsharma2 @shahar1 @jigarg