Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong casing in airbyte hook. #42170

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 11, 2024

Fixes: #42154


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Sep 11, 2024

cc: @marcosmarxm

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a easy fix :-D Did not went this step but would have saved a CI run fixing it immediately :-D

@potiuk
Copy link
Member Author

potiuk commented Sep 11, 2024

BTW. For the future @jscheffl - it's best to avoid "==" pinning in our deps. It would likely be better to add !=0.52.0 in the first PR (I will explain - using this example - on Friday).

@potiuk
Copy link
Member Author

potiuk commented Sep 11, 2024

Passed the airbyte tests - merging..

@potiuk potiuk merged commit 11b99dc into apache:main Sep 11, 2024
102 of 106 checks passed
@potiuk potiuk deleted the fix-wrong-casing-in-token-url branch September 11, 2024 19:04
@marcosmarxm
Copy link
Contributor

I'm in contact with the team is responsible with the airbyte-sdk library. It shouldn't be changed but anyway. I'm going to keep an eye on it. Thanks a lot @potiuk and @jscheffl for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airbyte API 0.52.0 breaks provider tests
3 participants