Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider fab auth manager deprecated methods removed #41720

Merged
merged 4 commits into from
Aug 26, 2024
Merged

provider fab auth manager deprecated methods removed #41720

merged 4 commits into from
Aug 26, 2024

Conversation

dirrao
Copy link
Contributor

@dirrao dirrao commented Aug 25, 2024

provider fab auth manager deprecated methods removed

  1. get_readable_dags
  2. get_editable_dags
  3. get_accessible_dags
  4. get_accessible_dag_ids
  5. get_readable_dag_ids
  6. init_role
  7. prefixed_dag_id

@dirrao dirrao added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 labels Aug 25, 2024
@dirrao dirrao requested review from eladkal and potiuk August 25, 2024 06:03
@dirrao dirrao self-assigned this Aug 25, 2024
jscheffl
jscheffl approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static checks are failing, else good to merge.

@dirrao
Copy link
Contributor Author

dirrao commented Aug 26, 2024

Static checks are failing, else good to merge.

It's resolved.

@vincbeck vincbeck merged commit b039183 into apache:main Aug 26, 2024
54 checks passed
@eladkal
Copy link
Contributor

eladkal commented Sep 2, 2024 •
edited
Loading

This one is not handled properly... It mixes core and provider. Providers dont have newsfragments. It also force us to cut fab provider 2.0.0 is that something we want to do now? (We can but I am not sure we should). Initially I wanted to handle all providers deprecations together as bulk for 2.11

@potiuk
Copy link
Member

potiuk commented Sep 2, 2024

Yesl This one should be reverted.

potiuk added a commit to potiuk/airflow that referenced this pull request Sep 2, 2024
@potiuk
Revert "Provider fab auth manager deprecated methods removed (apache#…
4a44b83 
…41720)"

This reverts commit b039183.
@potiuk
Copy link
Member

potiuk commented Sep 2, 2024

Revert PR here
#41960

potiuk added a commit that referenced this pull request Sep 2, 2024
@potiuk
Revert "Provider fab auth manager deprecated methods removed (#41720)" (
f161070 
#41960)

This reverts commit b039183.
@eladkal eladkal mentioned this pull request Sep 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincbeck vincbeck vincbeck approved these changes

@jscheffl jscheffl jscheffl approved these changes

@eladkal eladkal Awaiting requested review from eladkal

@potiuk potiuk Awaiting requested review from potiuk

Assignees

@dirrao dirrao

Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:providers provider:fab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirrao @eladkal @potiuk @jscheffl @vincbeck