fix: custom query should have precedence over default query in RedshiftToS3Operator #41634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
…ftToS3Operator Signed-off-by: Kacper Muda <[email protected]>
kacpermuda
force-pushed
the
fix-redshift-to-s3-custom-query
branch
from
ac55f67 to
11e50d6
Compare
potiuk
approved these changes
Aug 21, 2024
vincbeck
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small fix, in my opinion. When unloading data to S3, one can either pass custom select_query or provide schema and table so that default query is created (SELECT * FROM {self.schema}.{self.table}). After validation to some parameters has been added in #37861, when custom query is provided together with schema and table it's being overwritten by default query. I think that custom select_query should always have precedence, when provided.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.