-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dataset related python variable names to asset #41348
Conversation
9dcc589
to
35ac346
Compare
I have created #41424 to add the |
sure, will do |
c6538fa
to
875d372
Compare
35d6d6e
to
870ba33
Compare
…created as iter_asset_alias and notify_asset_alias_created
ee2b1b8
to
1c137e5
Compare
Just a quick update. I've done the test on my local end and it work fine. And the CI is finally green again! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly I did not read every line, but I think I read enough to be confident this is good…
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from #41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348 Since those docs only work on Airflow stable, we can only change this after 3.0
Why
as part of AIP-74
part of #42307
What
Rename the variable names in Airflow. DB, API, and UI changes will be done in the following PRs
Rename module
airflow.api_connexion.schemas.dataset_schema
asairflow.api_connexion.schemas.asset_schema
create_dataset_event_schema
ascreate_asset_event_schema
dataset_collection_schema
asasset_collection_schema
dataset_event_collection_schema
asasset_event_collection_schema
dataset_event_schema
asasset_event_schema
dataset_schema
asasset_schema
TaskOutletDatasetReferenceSchema
asTaskOutletAssetReferenceSchema
DagScheduleDatasetReferenceSchema
asDagScheduleAssetReferenceSchema
DatasetAliasSchema
asAssetAliasSchema
DatasetSchema
asAssetSchema
DatasetCollection
asAssetCollection
DatasetEventSchema
asAssetEventSchema
DatasetEventCollection
asAssetEventCollection
DatasetEventCollectionSchema
asAssetEventCollectionSchema
CreateDatasetEventSchema
asCreateAssetEventSchema
Rename module
airflow.datasets
asairflow.assets
Rename class
DatasetAlias
asAssetAlias
Rename class
DatasetAll
asAssetAll
Rename class
DatasetAny
asAssetAny
Rename function
expand_alias_to_datasets
asexpand_alias_to_assets
Rename class
DatasetAliasEvent
asAssetAliasEvent
dest_dataset_uri
asdest_asset_uri
Rename class
BaseDataset
asBaseAsset
iter_datasets
asiter_assets
iter_dataset_aliases
asiter_asset_aliases
Rename class
Dataset
asAsset
iter_datasets
asiter_assets
iter_dataset_aliases
asiter_asset_aliases
Rename class
_DatasetBooleanCondition
as_AssetBooleanCondition
iter_datasets
asiter_assets
iter_dataset_aliases
asiter_asset_aliases
Rename module
airflow.datasets.manager
asairflow.assets.manager
Rename variable
dataset_manager
asasset_manager
Rename function
resolve_dataset_manager
asresolve_asset_manager
Rename class
DatasetManager
asAssetManager
register_dataset_change
asregister_asset_change
create_datasets
ascreate_assets
register_dataset_change
asnotify_asset_created
notify_dataset_changed
asnotify_asset_changed
Rename module
airflow.models.dataset
asairflow.models.asset
DatasetDagRunQueue
asAssetDagRunQueue
DatasetEvent
asAssetEvent
DatasetModel
asAssetModel
DatasetAliasModel
asAssetAliasModel
DagScheduleDatasetReference
asDagScheduleAssetReference
TaskOutletDatasetReference
asTaskOutletAssetReference
DagScheduleDatasetAliasReference
asDagScheduleAssetAliasReference
Rename module
airflow.api_ui.views.datasets
asairflow.api_ui.views.assets
dataset_router
asasset_rounter
Rename module
airflow.listeners.spec.dataset
asairflow.listeners.spec.asset
on_dataset_created
ason_asset_created
on_dataset_changed
ason_asset_changed
Rename module
airflow.timetables.datasets
asairflow.timetables.assets
DatasetOrTimeSchedule
asAssetOrTimeSchedule
Rename module
airflow.serialization.pydantic.dataset
asairflow.serialization.pydantic.asset
DagScheduleDatasetReferencePydantic
asDagScheduleAssetReferencePydantic
TaskOutletDatasetReferencePydantic
asTaskOutletAssetReferencePydantic
DatasetPydantic
asAssetPydantic
DatasetEventPydantic
asAssetEventPydantic
Rename module
airflow.datasets.metadata
asairflow.assets.metadata
In module
airflow.jobs.scheduler_job_runner
and its class
SchedulerJobRunner
_create_dag_runs_dataset_triggered
as_create_dag_runs_asset_triggered
_orphan_unreferenced_datasets
as_orphan_unreferenced_datasets
In module
airflow.api_connexion.security
requires_access_dataset
asrequires_access_asset
In module
airflow.auth.managers.models.resource_details
DatasetDetails
asAssetDetails
In module
airflow.auth.managers.base_auth_manager
is_authorized_dataset
asis_authorized_asset
In module
airflow.timetables.simple
DatasetTriggeredTimetable
asAssetTriggeredTimetable
In module
airflow.lineage.hook
Rename class
DatasetLineageInfo
asAssetLineageInfo
dataset
asasset
In its class
HookLineageCollector
create_dataset
ascreate_asset
add_input_dataset
asadd_input_asset
add_output_dataset
asadd_output_asset
collected_datasets
ascollected_assets
In module
airflow.models.dag
Rename function
get_dataset_triggered_next_run_info
asget_asset_triggered_next_run_info
In its class
DagModel
get_dataset_triggered_next_run_info
asget_asset_triggered_next_run_info
In module
airflow.models.taskinstance
and its class
TaskInstance
_register_dataset_changes
as_register_asset_changes
In module
airflow.providers_manager
and its class
ProvidersManager
initialize_providers_dataset_uri_resources
asinitialize_providers_asset_uri_resources
_discover_dataset_uri_resources
as_discover_asset_uri_resources
dataset_factories
asasset_factories
dataset_uri_handlers
asasset_uri_handlers
dataset_to_openlineage_converters
asasset_to_openlineage_converters
In module
airflow.security.permissions
RESOURCE_DATASET
asRESOURCE_ASSET
In module
airflow.serialization.enums
and its class DagAttributeTypes
DATASET_EVENT_ACCESSORS
asASSET_EVENT_ACCESSORS
DATASET_EVENT_ACCESSOR
asASSET_EVENT_ACCESSOR
DATASET
asASSET
DATASET_ALIAS
asASSET_ALIAS
DATASET_ANY
asASSET_ANY
DATASET_ALL
asASSET_ALL
In module
airflow.serialization.pydantic.taskinstance
and its class
TaskInstancePydantic
_register_dataset_changes
as_register_dataset_changes
In module
airflow.serialization.serialized_objects
encode_dataset_condition
asencode_asset_condition
decode_dataset_condition
asdecode_asset_condition
In module
airflow.timetables.base
Rename class
_NullDataset
as_NullAsset
iter_datasets
asiter_assets
In module
airflow.utils.context
LazyDatasetEventSelectSequence
asLazyAssetEventSelectSequence
In module
airflow.www.auth
has_access_dataset
ashas_access_asset
Rename configuration
core.strict_dataset_uri_validation
ascore.strict_asset_uri_validation
,core.dataset_manager_class
ascore.asset_manager_class
andcore.dataset_manager_class
ascore.asset_manager_class
Rename example dags
example_dataset_alias.py
,example_dataset_alias_with_no_taskflow.py
,example_datasets.py
asexample_asset_alias.py
,example_asset_alias_with_no_taskflow.py
,example_assets.py
Rename DagDependency name
dataset-alias
,dataset
asasset-alias
,asset
Rename context key
triggering_dataset_events
astriggering_asset_events
Rename resource key
dataset-uris
asasset-uris
for providers amazon, common.io, mysql, fab, postgres, trinoIn provider
airflow.providers.amazon.aws
Rename package
datasets
asassets
In its module
s3
create_dataset
ascreate_asset
convert_dataset_to_openlineage
asconvert_asset_to_openlineage
and its module
auth_manager.avp.entities
AvpEntities.DATASET
asAvpEntities.ASSET
and its module
auth_manager.auth_manager.aws_auth_manager
is_authorized_dataset
asis_authorized_asset
In provider
airflow.providers.common.io
Rename package
datasets
asassets
in its module
file
create_dataset
ascreate_asset
convert_dataset_to_openlineage
asconvert_asset_to_openlineage
In provider
airflow.providers.fab
in its module
auth_manager.fab_auth_manager
is_authorized_dataset
asis_authorized_asset
In provider
airflow.providers.openlineage
in its module
utils.utils
DatasetInfo
asAssetInfo
translate_airflow_dataset
astranslate_airflow_asset
Rename package
airflow.providers.postgres.datasets
asairflow.providers.postgres.assets
Rename package
airflow.providers.mysql.datasets
asairflow.providers.mysql.assets
Rename package
airflow.providers.trino.datasets
asairflow.providers.trino.assets
Add module
airflow.providers.common.compat.assets
Add module
airflow.providers.common.compat.openlineage.utils.utils
Add moddule
airflow.providers.common.compat.security.permissions.RESOURCE_ASSET
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.