Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-461] Restore parameter position for BQ run_load method #4077

Merged
merged 1 commit into from
Oct 22, 2018
Merged

[AIRFLOW-461] Restore parameter position for BQ run_load method #4077

merged 1 commit into from
Oct 22, 2018

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 22, 2018

This is just a follow-up PR to #3880 as I didn't have write permission to forked repo. This PR just restores parameter position for schema_fields param

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8

@kaxil kaxil merged commit cc360e5 into master Oct 22, 2018
@kaxil kaxil deleted the kaxil-patch-1 branch October 22, 2018 09:30
@ashb
Copy link
Member

ashb commented Oct 22, 2018

This failed flake8 tests with a syntax error.

kaxil added a commit that referenced this pull request Oct 22, 2018
@kaxil
Revert "[AIRFLOW-461] Restore parameter position for BQ run_load meth…
51f5427 
…od (#4077)"

This reverts commit cc360e5.
@kaxil
Copy link
Member Author

kaxil commented Oct 22, 2018

Well ofcourse.. It was stupid of me.. :D Reverted this

non-default argument follows default argument

tekn0ir pushed a commit to tekn0ir/incubator-airflow that referenced this pull request Oct 26, 2018
Merge branch 'master' into kubernetes
2b0f007 
* master:
  [AIRFLOW-520] Fix Version Info in Flask UI (apache#4072)
  [AIRFLOW-XXX] Add Neoway to companies list (apache#4081)
  [AIRFLOW-XXX] Add Surfline to companies list (apache#4079)
  Revert "[AIRFLOW-461] Restore parameter position for BQ run_load method (apache#4077)"
  [AIRFLOW-461] Restore parameter position for BQ run_load method (apache#4077)
  [AIRFLOW-461]  Support autodetected schemas in BigQuery run_load (apache#3880)
  [AIRFLOW-3238] Fix models.DAG to deactivate unknown DAGs on initdb (apache#4073)
  [AIRFLOW-3239] Fix test recovery further (apache#4074)
  [AIRFLOW-3203] Fix DockerOperator & some operator test (apache#4049)
  [AIRFLOW-1867] Add sandbox mode and py3k bug  (apache#2824)
  [AIRFLOW-2993] s3_to_sftp and sftp_to_s3 operators (apache#3828)
  [AIRFLOW-XXX] BigQuery Hook - Minor Refactoring (apache#4066)
  [AIRFLOW-3232] More readable GCF operator documentation (apache#4067)
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
@kaxil
[AIRFLOW-461] Restore parameter position for BQ run_load method (apac…
e27af72 
…he#4077)
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
@kaxil
Revert "[AIRFLOW-461] Restore parameter position for BQ run_load meth…
a019226 
…od (apache#4077)"

This reverts commit cc360e5.
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
@kaxil
[AIRFLOW-461] Restore parameter position for BQ run_load method (apac…
fa5240f 
…he#4077)
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
@kaxil
Revert "[AIRFLOW-461] Restore parameter position for BQ run_load meth…
8247326 
…od (apache#4077)"

This reverts commit cc360e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxil @ashb