openlineage: fix / add some task attributes in AirflowRunFacet #40725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobuchowski
approved these changes
Jul 11, 2024
mobuchowski
requested changes
Jul 11, 2024
kacpermuda
force-pushed
the
ol-fix-some-task-attributes
branch
from
fc5f8dd to
ac702e4
Compare
…owRunFacet Signed-off-by: Kacper Muda <[email protected]>
Signed-off-by: Kacper Muda <[email protected]>
Signed-off-by: Kacper Muda <[email protected]>
kacpermuda
force-pushed
the
ol-fix-some-task-attributes
branch
from
ac702e4 to
e994960
Compare
mobuchowski
approved these changes
Jul 12, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…e#40725) * openlineage: Only include Airflow Datasets as inlets/outlets in AirflowRunFacet Signed-off-by: Kacper Muda <[email protected]> * openlineage: Add full path to operator in AirflowRunFacet Signed-off-by: Kacper Muda <[email protected]> * openlineage: Add documentation facet when translating from Table entity Signed-off-by: Kacper Muda <[email protected]> --------- Signed-off-by: Kacper Muda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only include operator name in TaskInfo, this PR adds the full path to the operator. It should be easier to identify them in case there are multiple operators with the same name.
Also, inlets and outlets added in #40371 only make sense for Datasets so this PR only takes those into consideration. All other lineage entities (File, Table) are already translated into input / output datasets here.
When I'm at it, I'm extending the translation from Table with DocumentationDatasetFacet.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.