-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validating provider description for urls in provider list view #40475
Merged
ephraimbuddy
merged 2 commits into
apache:main
from
amoghrajesh:validateURIinListProviders
Jun 28, 2024
Merged
Validating provider description for urls in provider list view #40475
ephraimbuddy
merged 2 commits into
apache:main
from
amoghrajesh:validateURIinListProviders
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
June 28, 2024 06:20
Lee-W
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. should we add a test to it?
Yes it makes sense to add a test for this, @Lee-W can you take a look? |
Lee-W
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ephraimbuddy
approved these changes
Jun 28, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Validating provider description for urls in provider list view * adding unit tests --------- Co-authored-by: adesai <[email protected]> (cherry picked from commit f18f484)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Validating provider description for urls in provider list view * adding unit tests --------- Co-authored-by: adesai <[email protected]> (cherry picked from commit f18f484)
35 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…e#40475) * Validating provider description for urls in provider list view * adding unit tests --------- Co-authored-by: adesai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating URLs in Provider Descriptions for Provider List View
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.