-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TriggeredDagRunOperator triggered link #40336
Fix TriggeredDagRunOperator triggered link #40336
Conversation
e41d994
to
ec04aaf
Compare
Link to the specific dag run id that was triggered, as opposed to the logical date, such that the instance that was triggered on the DAG grid UI.
21bff51
to
9f949b0
Compare
Hi all, I think the URL should include both the execution_date and the dag_run_id. Because if you only include the dag_run_id it will not work if that value is not in the 25 latest dag runs (or whatever you've set as |
Why not? |
If you refer to #39642 it has already been fixed |
Has the way url's are processed changed since the release of 2.9.2? Because now I see changes in how the url's are generated, but not in how they are processed. Because I'm unable to build the latest version locally, so I'm testing on 2.9.2, but I can manually create url's based on what I see in the code/screenshots. If I look at the url visible in the screenshot and substitute the values for my own setup, I get an URL that doesn't work for DagRuns not in the latest 25. So I have If I make it (I'm quite sceptical about #396442 actually being fixed by that MR.) |
The PR I shared is targeted to 2.9.3 which hasnt been released yet. If you want to report a problem please first check with main branch. If you find a bug you can open Github issue with the reporduce example |
* Fix TriggeredDagRunOperator triggered link Link to the specific dag run id that was triggered, as opposed to the logical date, such that the instance that was triggered on the DAG grid UI. * Add comment regarding triggered dag xcom (cherry picked from commit 806bb80)
* Fix TriggeredDagRunOperator triggered link Link to the specific dag run id that was triggered, as opposed to the logical date, such that the instance that was triggered on the DAG grid UI. * Add comment regarding triggered dag xcom (cherry picked from commit 806bb80)
* Fix TriggeredDagRunOperator triggered link Link to the specific dag run id that was triggered, as opposed to the logical date, such that the instance that was triggered on the DAG grid UI. * Add comment regarding triggered dag xcom
Link to the specific dag run id that was triggered, as opposed to the logical date, such that the instance that was triggered on the DAG grid UI.
This was alluded to in #19264, but you want the DAG run that was triggered select in the DAG grid UI.
Current link and DAG grid UI view:
This PR's changed link and DAG grid UI view:
Simple DAGs to demonstrate:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.